From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2181) id E09C2393D014; Wed, 28 Apr 2021 15:13:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E09C2393D014 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jonathan Wakely To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r12-217] libstdc++: Define __cpp_lib_constexpr_string macro X-Act-Checkin: gcc X-Git-Author: Jonathan Wakely X-Git-Refname: refs/heads/master X-Git-Oldrev: 43a35b26e2fd2fab9c0c3ebac67e3a6c439daef4 X-Git-Newrev: 3da80ed7efd582575e7850a403ce693ec882d087 Message-Id: <20210428151336.E09C2393D014@sourceware.org> Date: Wed, 28 Apr 2021 15:13:36 +0000 (GMT) X-BeenThere: libstdc++-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Apr 2021 15:13:37 -0000 https://gcc.gnu.org/g:3da80ed7efd582575e7850a403ce693ec882d087 commit r12-217-g3da80ed7efd582575e7850a403ce693ec882d087 Author: Jonathan Wakely Date: Wed Apr 28 15:56:04 2021 +0100 libstdc++: Define __cpp_lib_constexpr_string macro As noted in r11-1339-gb6ab9ecd550227684643b41e9e33a4d3466724d8 we define a non-standard __cpp_lib_constexpr_char_traits feature test macro to indicate support for P0426R1 and P1032R1. At some point last year the __cpp_lib_constexpr_string macro was retconned to indicate support for those papers. This adds the new macro (which we didn't previously define, because it referred to P0980R1 "Making std::string constexpr" which we don't support). libstdc++-v3/ChangeLog: * include/bits/basic_string.h (__cpp_lib_constexpr_string): Define. * include/std/version (__cpp_lib_constexpr_string): Define. * testsuite/21_strings/char_traits/requirements/constexpr_functions_c++17.cc: Check for __cpp_lib_constexpr_string. * testsuite/21_strings/char_traits/requirements/constexpr_functions_c++20.cc: Likewise. * testsuite/21_strings/char_traits/requirements/version.cc: New test. Diff: --- libstdc++-v3/include/bits/basic_string.h | 9 ++++++++- libstdc++-v3/include/std/version | 2 ++ .../requirements/constexpr_functions_c++17.cc | 11 ++++++++--- .../requirements/constexpr_functions_c++20.cc | 7 +++++++ .../21_strings/char_traits/requirements/version.cc | 16 ++++++++++++++++ 5 files changed, 41 insertions(+), 4 deletions(-) diff --git a/libstdc++-v3/include/bits/basic_string.h b/libstdc++-v3/include/bits/basic_string.h index 3c5309d16e6..41d781c698e 100644 --- a/libstdc++-v3/include/bits/basic_string.h +++ b/libstdc++-v3/include/bits/basic_string.h @@ -48,11 +48,18 @@ # include #endif - namespace std _GLIBCXX_VISIBILITY(default) { _GLIBCXX_BEGIN_NAMESPACE_VERSION +#if __cplusplus == 201703L +// Support P0426R1 changes to char_traits in C++17. +# define __cpp_lib_constexpr_string 201611L +#else +// Also support P1032R1 in C++20 (but not P0980R1 yet). +# define __cpp_lib_constexpr_string 201811L +#endif + #if _GLIBCXX_USE_CXX11_ABI _GLIBCXX_BEGIN_NAMESPACE_CXX11 /** diff --git a/libstdc++-v3/include/std/version b/libstdc++-v3/include/std/version index d9f6a3c3dfd..09e67a40d0c 100644 --- a/libstdc++-v3/include/std/version +++ b/libstdc++-v3/include/std/version @@ -131,6 +131,7 @@ #define __cpp_lib_clamp 201603 #if __cplusplus == 201703L // N.B. updated value in C++20 # define __cpp_lib_constexpr_char_traits 201611L +# define __cpp_lib_constexpr_string 201611L #endif #define __cpp_lib_enable_shared_from_this 201603 #define __cpp_lib_execution 201902L // FIXME: should be 201603L @@ -219,6 +220,7 @@ #define __cpp_lib_constexpr_iterator 201811L #define __cpp_lib_constexpr_memory 201811L #define __cpp_lib_constexpr_numeric 201911L +#define __cpp_lib_constexpr_string 201811L #define __cpp_lib_constexpr_string_view 201811L #define __cpp_lib_constexpr_tuple 201811L #define __cpp_lib_constexpr_utility 201811L diff --git a/libstdc++-v3/testsuite/21_strings/char_traits/requirements/constexpr_functions_c++17.cc b/libstdc++-v3/testsuite/21_strings/char_traits/requirements/constexpr_functions_c++17.cc index 803fb68df09..32e31e13abb 100644 --- a/libstdc++-v3/testsuite/21_strings/char_traits/requirements/constexpr_functions_c++17.cc +++ b/libstdc++-v3/testsuite/21_strings/char_traits/requirements/constexpr_functions_c++17.cc @@ -73,12 +73,17 @@ template return true; } +#ifndef __cpp_lib_constexpr_string +# error Feature-test macro for constexpr char_traits is missing +#elif __cpp_lib_constexpr_string < (__cplusplus == 201703 ? 201611 : 201811) +# error Feature-test macro for constexpr char_traits has the wrong value +#endif + +// We also provide this non-standard macro for P0426R1 (and P1032R1 in C++20). #ifndef __cpp_lib_constexpr_char_traits # error Feature-test macro for constexpr char_traits is missing -#elif __cpp_lib_constexpr_char_traits < 201611 +#elif __cpp_lib_constexpr_char_traits != (__cplusplus == 201703 ? 201611 : 201811) # error Feature-test macro for constexpr char_traits has the wrong value -#elif __cpp_lib_constexpr_char_traits > 201611 && __cplusplus == 201703 -# error Feature-test macro for constexpr char_traits has wrong value for C++17 #endif static_assert( test_assign>() ); diff --git a/libstdc++-v3/testsuite/21_strings/char_traits/requirements/constexpr_functions_c++20.cc b/libstdc++-v3/testsuite/21_strings/char_traits/requirements/constexpr_functions_c++20.cc index 0c1329f903d..0d1595fe030 100644 --- a/libstdc++-v3/testsuite/21_strings/char_traits/requirements/constexpr_functions_c++20.cc +++ b/libstdc++-v3/testsuite/21_strings/char_traits/requirements/constexpr_functions_c++20.cc @@ -30,6 +30,13 @@ template return s1[0]==char_type{1} && s1[1]==char_type{1} && s1[2]==char_type{2}; } +#ifndef __cpp_lib_constexpr_string +# error Feature-test macro for constexpr char_traits is missing +#elif __cpp_lib_constexpr_string < 201811 +# error Feature-test macro for constexpr char_traits has the wrong value +#endif + +// We also provide this non-standard macro for P0426R1 and P1032R1. #ifndef __cpp_lib_constexpr_char_traits # error Feature-test macro for constexpr char_traits is missing #elif __cpp_lib_constexpr_char_traits != 201811 diff --git a/libstdc++-v3/testsuite/21_strings/char_traits/requirements/version.cc b/libstdc++-v3/testsuite/21_strings/char_traits/requirements/version.cc new file mode 100644 index 00000000000..6f571f48010 --- /dev/null +++ b/libstdc++-v3/testsuite/21_strings/char_traits/requirements/version.cc @@ -0,0 +1,16 @@ +// { dg-do compile { target c++17 } } + +#include + +#ifndef __cpp_lib_constexpr_string +# error Feature-test macro for constexpr char_traits is missing in +#elif __cpp_lib_constexpr_string < (__cplusplus == 201703 ? 201611 : 201811) +# error Feature-test macro for constexpr char_traits has the wrong value in +#endif + +// We also provide this non-standard macro for P0426R1 and P1032R1. +#ifndef __cpp_lib_constexpr_char_traits +# error Feature-test macro for constexpr char_traits is missing in +#elif __cpp_lib_constexpr_char_traits != (__cplusplus == 201703 ? 201611 : 201811) +# error Feature-test macro for constexpr char_traits has the wrong value in +#endif