public inbox for libstdc++-cvs@sourceware.org help / color / mirror / Atom feed
From: Jonathan Wakely <redi@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r12-512] libstdc++: Use unsigned char argument to std::isdigit Date: Wed, 5 May 2021 12:00:55 +0000 (GMT) [thread overview] Message-ID: <20210505120055.7745339A6056@sourceware.org> (raw) https://gcc.gnu.org/g:d0d6ca019717305df0ef41e3fe1da48f7f561fac commit r12-512-gd0d6ca019717305df0ef41e3fe1da48f7f561fac Author: Jonathan Wakely <jwakely@redhat.com> Date: Wed May 5 11:19:55 2021 +0100 libstdc++: Use unsigned char argument to std::isdigit Passing plain char to isdigit is undefined if the value is negative. libstdc++-v3/ChangeLog: * include/std/charconv (__from_chars_alnum): Pass unsigned char to std::isdigit. Diff: --- libstdc++-v3/include/std/charconv | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libstdc++-v3/include/std/charconv b/libstdc++-v3/include/std/charconv index 193702e677a..571be075a6b 100644 --- a/libstdc++-v3/include/std/charconv +++ b/libstdc++-v3/include/std/charconv @@ -565,7 +565,7 @@ namespace __detail while (__first != __last) { unsigned char __c = *__first; - if (std::isdigit(__c)) + if (std::isdigit(static_cast<unsigned char>(__c))) __c -= '0'; else {
reply other threads:[~2021-05-05 12:00 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210505120055.7745339A6056@sourceware.org \ --to=redi@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ --cc=libstdc++-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).