public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jonathan Wakely <redi@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org
Subject: [gcc r11-8396] libstdc++: Remove TODO comment
Date: Tue, 11 May 2021 19:52:02 +0000 (GMT)	[thread overview]
Message-ID: <20210511195202.6041C398D046@sourceware.org> (raw)

https://gcc.gnu.org/g:16255fd2fdbf801167c2a5f095048b2c7824f6be

commit r11-8396-g16255fd2fdbf801167c2a5f095048b2c7824f6be
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon May 10 21:06:22 2021 +0100

    libstdc++: Remove TODO comment
    
    We have a comment saying to replace the simple binary_semaphore type
    with std::binary_semaphore, which has been done. However, that isn't
    defined on all targets. So keep the simple one here that just implements
    the parts of the API needed by <stop_token>, and remove the comment
    suggesting it should be replaced.
    
    libstdc++-v3/ChangeLog:
    
            * include/std/stop_token: Remove TODO comment.
    
    (cherry picked from commit 151154a21da8b0784894b2463a117f4e283d5525)

Diff:
---
 libstdc++-v3/include/std/stop_token | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libstdc++-v3/include/std/stop_token b/libstdc++-v3/include/std/stop_token
index fffc215d2a8..d0cfcf31097 100644
--- a/libstdc++-v3/include/std/stop_token
+++ b/libstdc++-v3/include/std/stop_token
@@ -107,7 +107,6 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
     }
 
 #ifndef __cpp_lib_semaphore
-    // TODO: replace this with a real implementation of std::binary_semaphore
     struct binary_semaphore
     {
       explicit binary_semaphore(int __d) : _M_counter(__d > 0) { }


                 reply	other threads:[~2021-05-11 19:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210511195202.6041C398D046@sourceware.org \
    --to=redi@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    --cc=libstdc++-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).