From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2181) id 7AE67386197D; Fri, 18 Jun 2021 10:15:43 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7AE67386197D MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" From: Jonathan Wakely To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r12-1641] libstdc++: Suppress -Wstringop-overread warning in test X-Act-Checkin: gcc X-Git-Author: Jonathan Wakely X-Git-Refname: refs/heads/master X-Git-Oldrev: 76e990fd211cbb20bf74ce074eb8b2d7b096d3b7 X-Git-Newrev: 92edc4a7684cdad5d30e197b976c35b2257f7bed Message-Id: <20210618101543.7AE67386197D@sourceware.org> Date: Fri, 18 Jun 2021 10:15:43 +0000 (GMT) X-BeenThere: libstdc++-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Jun 2021 10:15:43 -0000 https://gcc.gnu.org/g:92edc4a7684cdad5d30e197b976c35b2257f7bed commit r12-1641-g92edc4a7684cdad5d30e197b976c35b2257f7bed Author: Jonathan Wakely Date: Fri Jun 18 11:08:19 2021 +0100 libstdc++: Suppress -Wstringop-overread warning in test When compiled with -m32 -O2 -D_GLIBCXX_USE_CXX11_ABI=0 we get a warning for 21_strings/basic_string/cons/char/1.cc: bits/char_traits.h:409:56: warning: ‘void* __builtin_memcpy(void*, const void*, unsigned int)’ reading 1073741821 bytes from a region of size 19 [-Wstringop-overread] The warning is legitimate, even if that line cannot be reached because we throw std::length_error before getting there. Since the invalid length is deliberate (and mentioned in a comment) just suppress the warning, so that the test can verify we get the exception. Also remove an unused typedef that produces another warning. libstdc++-v3/ChangeLog: * testsuite/21_strings/basic_string/cons/char/1.cc: Use diagnostic pragma to suppress -Wstringop-overread error. Signed-off-by: Jonathan Wakely Diff: --- libstdc++-v3/testsuite/21_strings/basic_string/cons/char/1.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libstdc++-v3/testsuite/21_strings/basic_string/cons/char/1.cc b/libstdc++-v3/testsuite/21_strings/basic_string/cons/char/1.cc index 5549094553e..099921f0941 100644 --- a/libstdc++-v3/testsuite/21_strings/basic_string/cons/char/1.cc +++ b/libstdc++-v3/testsuite/21_strings/basic_string/cons/char/1.cc @@ -36,7 +36,6 @@ using namespace std; void test01(void) { typedef string::size_type csize_type; - typedef string::iterator citerator; csize_type npos = string::npos; csize_type csz01; @@ -68,6 +67,8 @@ void test01(void) // basic_string(const char* s, size_type n, alloc) csz01 = str01.max_size(); +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wstringop-overread" // NB: As strlen(str_lit01) != csz01, this test is undefined. It // should not crash, but what gets constructed is a bit arbitrary. try { @@ -94,6 +95,7 @@ void test01(void) catch(...) { VERIFY( false ); } +#pragma GCC diagnostic pop // Build a maxsize - 1 lengthed string consisting of all A's try {