public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jonathan Wakely <redi@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org
Subject: [gcc r9-9589] libstdc++: Fix find_type helper to work consistently
Date: Fri, 18 Jun 2021 14:43:24 +0000 (GMT)	[thread overview]
Message-ID: <20210618144324.85BFD3AA9825@sourceware.org> (raw)

https://gcc.gnu.org/g:3f023bc5bb3d260ffe7d6e1f333fb41bbbbae444

commit r9-9589-g3f023bc5bb3d260ffe7d6e1f333fb41bbbbae444
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Thu Mar 11 16:48:32 2021 +0000

    libstdc++: Fix find_type helper to work consistently
    
    The find_type helper function sometimes results in "class X::name" and
    lookup for that fails. For more details see "Problem 1" in
    https://gcc.gnu.org/pipermail/libstdc++/2021-March/052132.html and the
    example at https://sourceware.org/bugzilla/show_bug.cgi?id=27510#c2
    
    This patch replaces typ.unqualified() with typ.tag, which is never
    qualified, and will never include the 'class' or 'struct' keywords.
    Using the .tag attribute should be safe here because we know we are
    looking at a class type and we've already used strip_typedefs().
    
    libstdc++-v3/ChangeLog:
    
            * python/libstdcxx/v6/printers.py (find_type): Use tag attribute
            instead of unqualified() method.
    
    (cherry picked from commit 9dacc828bf8b087ddfaf797ed7238da45609082c)

Diff:
---
 libstdc++-v3/python/libstdcxx/v6/printers.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libstdc++-v3/python/libstdcxx/v6/printers.py b/libstdc++-v3/python/libstdcxx/v6/printers.py
index 32b8210414a..0c94a038437 100644
--- a/libstdc++-v3/python/libstdcxx/v6/printers.py
+++ b/libstdc++-v3/python/libstdcxx/v6/printers.py
@@ -85,8 +85,8 @@ except ImportError:
 def find_type(orig, name):
     typ = orig.strip_typedefs()
     while True:
-        # Strip cv-qualifiers.  PR 67440.
-        search = '%s::%s' % (typ.unqualified(), name)
+        # Use Type.tag to ignore cv-qualifiers.  PR 67440.
+        search = '%s::%s' % (typ.tag, name)
         try:
             return gdb.lookup_type(search)
         except RuntimeError:


                 reply	other threads:[~2021-06-18 14:43 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210618144324.85BFD3AA9825@sourceware.org \
    --to=redi@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    --cc=libstdc++-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).