public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jonathan Wakely <redi@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org
Subject: [gcc r12-5421] libstdc++: One more change for Clang to support constexpr std::string [PR103295]
Date: Fri, 19 Nov 2021 20:19:03 +0000 (GMT)	[thread overview]
Message-ID: <20211119201903.E3C633858413@sourceware.org> (raw)

https://gcc.gnu.org/g:1f8d01eb1476a997eb1fc686b60fccdf97747faa

commit r12-5421-g1f8d01eb1476a997eb1fc686b60fccdf97747faa
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Fri Nov 19 18:27:59 2021 +0000

    libstdc++: One more change for Clang to support constexpr std::string [PR103295]
    
    All writes into the allocated buffer need to be via traits_type::assign
    to begin lifetimes.
    
    libstdc++-v3/ChangeLog:
    
            PR libstdc++/103295
            * include/bits/basic_string.tcc (_M_construct): Use the
            traits assign member to write into allcoated memory.

Diff:
---
 libstdc++-v3/include/bits/basic_string.tcc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libstdc++-v3/include/bits/basic_string.tcc b/libstdc++-v3/include/bits/basic_string.tcc
index 374406c0e13..6f619a08f70 100644
--- a/libstdc++-v3/include/bits/basic_string.tcc
+++ b/libstdc++-v3/include/bits/basic_string.tcc
@@ -201,7 +201,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
 		_M_data(__another);
 		_M_capacity(__capacity);
 	      }
-	    _M_data()[__len++] = *__beg;
+	    traits_type::assign(_M_data()[__len++], *__beg);
 	    ++__beg;
 	  }


                 reply	other threads:[~2021-11-19 20:19 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211119201903.E3C633858413@sourceware.org \
    --to=redi@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    --cc=libstdc++-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).