From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2181) id 861E0385842D; Mon, 13 Dec 2021 11:16:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 861E0385842D MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jonathan Wakely To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r12-5925] libstdc++: Make ranges::size and ranges::empty check for unbounded arrays X-Act-Checkin: gcc X-Git-Author: Jonathan Wakely X-Git-Refname: refs/heads/master X-Git-Oldrev: ef5d671cd80a4afa4f74c3dfe2904c63f51fcfde X-Git-Newrev: 55823c5a0ba50022d7fcc95e74ec293143810ef6 Message-Id: <20211213111620.861E0385842D@sourceware.org> Date: Mon, 13 Dec 2021 11:16:20 +0000 (GMT) X-BeenThere: libstdc++-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Dec 2021 11:16:20 -0000 https://gcc.gnu.org/g:55823c5a0ba50022d7fcc95e74ec293143810ef6 commit r12-5925-g55823c5a0ba50022d7fcc95e74ec293143810ef6 Author: Jonathan Wakely Date: Sun Dec 12 21:16:25 2021 +0000 libstdc++: Make ranges::size and ranges::empty check for unbounded arrays Passing IncompleteType(&)[] to ranges::begin produces an error outside the immediate context, which is fine for ranges::begin, but it means that we fail to enforce the SFINAE-able constraints for ranges::size and ranges::size. They should not be callable for any array of unknown bound, whether the type is complete or not. Because we don't enforce that in their constraints, we get a hard error when they try to use ranges::begin. This simply adds explicit checks for arrays of unknown bound to the constraints for ranges::size and ranges::empty. We only need to check it for the __sentinel_size and __eq_iter_empty concepts, because those are the ones that are relevant to arrays, and which try to use ranges::begin. libstdc++-v3/ChangeLog: * include/bits/ranges_base.h (ranges::size, ranges::empty): Add explicit check for unbounded arrays before using ranges::begin. * testsuite/std/ranges/access/empty.cc: Check handling of unbounded arrays. * testsuite/std/ranges/access/size.cc: Likewise. Diff: --- libstdc++-v3/include/bits/ranges_base.h | 4 ++++ libstdc++-v3/testsuite/std/ranges/access/empty.cc | 10 ++++++++++ libstdc++-v3/testsuite/std/ranges/access/size.cc | 10 ++++++++++ 3 files changed, 24 insertions(+) diff --git a/libstdc++-v3/include/bits/ranges_base.h b/libstdc++-v3/include/bits/ranges_base.h index 43b0b9f7bf3..bf95823668b 100644 --- a/libstdc++-v3/include/bits/ranges_base.h +++ b/libstdc++-v3/include/bits/ranges_base.h @@ -383,6 +383,8 @@ namespace ranges template concept __sentinel_size = requires(_Tp& __t) { + requires (!is_unbounded_array_v>); + { _Begin{}(__t) } -> forward_iterator; { _End{}(__t) } -> sized_sentinel_for; @@ -466,6 +468,8 @@ namespace ranges template concept __eq_iter_empty = requires(_Tp& __t) { + requires (!is_unbounded_array_v>); + { _Begin{}(__t) } -> forward_iterator; bool(_Begin{}(__t) == _End{}(__t)); diff --git a/libstdc++-v3/testsuite/std/ranges/access/empty.cc b/libstdc++-v3/testsuite/std/ranges/access/empty.cc index 3cad4740124..83b40872bd4 100644 --- a/libstdc++-v3/testsuite/std/ranges/access/empty.cc +++ b/libstdc++-v3/testsuite/std/ranges/access/empty.cc @@ -121,6 +121,16 @@ test04() static_assert( ! noexcept(std::ranges::empty(E3{})) ); } +template + concept has_empty = requires (T& t) { std::ranges::empty(t); }; + +// If T is an array of unknown bound, ranges::empty(E) is ill-formed. +static_assert( ! has_empty ); +static_assert( ! has_empty ); +static_assert( ! has_empty ); +struct Incomplete; +static_assert( ! has_empty ); + int main() { diff --git a/libstdc++-v3/testsuite/std/ranges/access/size.cc b/libstdc++-v3/testsuite/std/ranges/access/size.cc index c7e4f78f96a..24857975f7b 100644 --- a/libstdc++-v3/testsuite/std/ranges/access/size.cc +++ b/libstdc++-v3/testsuite/std/ranges/access/size.cc @@ -122,6 +122,16 @@ test06() static_assert( std::ranges::size(R{}) == 42 ); } +template + concept has_size = requires (T& t) { std::ranges::size(t); }; + +// If T is an array of unknown bound, ranges::size(E) is ill-formed. +static_assert( ! has_size ); +static_assert( ! has_size ); +static_assert( ! has_size ); +struct Incomplete; +static_assert( ! has_size ); + int main() {