public inbox for libstdc++-cvs@sourceware.org help / color / mirror / Atom feed
From: Jonathan Wakely <redi@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r12-7938] libstdc++: Add comment about memalign requirements Date: Thu, 31 Mar 2022 15:21:23 +0000 (GMT) [thread overview] Message-ID: <20220331152123.616413858C54@sourceware.org> (raw) https://gcc.gnu.org/g:7f016919fc8a042b83812ae5f34946ef23b7adb3 commit r12-7938-g7f016919fc8a042b83812ae5f34946ef23b7adb3 Author: Jonathan Wakely <jwakely@redhat.com> Date: Wed Mar 30 16:57:27 2022 +0100 libstdc++: Add comment about memalign requirements The memalign man page on Solaris and QNX lists an additional requirement for the alignment value that is not present in all implementation of that non-standard function. For both those targets we should actually be using posix_memalign anyway, so it doesn't matter. This just adds a comment making note of that fact. libstdc++-v3/ChangeLog: * libsupc++/new_opa.cc (aligned_alloc): Add comment. Diff: --- libstdc++-v3/libsupc++/new_opa.cc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libstdc++-v3/libsupc++/new_opa.cc b/libstdc++-v3/libsupc++/new_opa.cc index 5f24737de1c..411cd8d98b2 100644 --- a/libstdc++-v3/libsupc++/new_opa.cc +++ b/libstdc++-v3/libsupc++/new_opa.cc @@ -87,6 +87,8 @@ aligned_alloc (std::size_t al, std::size_t sz) static inline void* aligned_alloc (std::size_t al, std::size_t sz) { + // Solaris requires al >= sizeof a word and QNX requires >= sizeof(void*) + // but they both provide posix_memalign, so will use the definition above. return memalign (al, sz); } #else // !HAVE__ALIGNED_MALLOC && !HAVE_POSIX_MEMALIGN && !HAVE_MEMALIGN
reply other threads:[~2022-03-31 15:21 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220331152123.616413858C54@sourceware.org \ --to=redi@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ --cc=libstdc++-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).