public inbox for libstdc++-cvs@sourceware.org help / color / mirror / Atom feed
From: Jonathan Wakely <redi@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r12-8465] libstdc++: Mark non-exported function always_inline [PR105671] Date: Wed, 8 Jun 2022 15:53:03 +0000 (GMT) [thread overview] Message-ID: <20220608155303.83325385087C@sourceware.org> (raw) https://gcc.gnu.org/g:d47c4f0f1da0aa84097878b82e100d08deb6d950 commit r12-8465-gd47c4f0f1da0aa84097878b82e100d08deb6d950 Author: Jonathan Wakely <jwakely@redhat.com> Date: Fri May 27 12:43:18 2022 +0100 libstdc++: Mark non-exported function always_inline [PR105671] This new function was added for gcc 11.1 but is not exported from the shared library. Depending on inlining decisions, its callers might get inlined but an external definition be needed for this function. That then fails to link. Since we can't add the export to the gcc-11 release branch now, mark it always_inline. We can consider exporting it for gcc-13 if/when we bump the shared library version (and maybe also for gcc-12 which is currently at the same version as trunk). For now, the attribute will solve the problem on all affected branches. The function is small enough that force-inlining it shouldn't cause problems. libstdc++-v3/ChangeLog: PR libstdc++/105671 * include/std/sstream (basic_stringbuf::_M_high_mark): Add always_inline attribute. (cherry picked from commit de57440858591a88e8fd7ba2505ca54546c86021) Diff: --- libstdc++-v3/include/std/sstream | 1 + 1 file changed, 1 insertion(+) diff --git a/libstdc++-v3/include/std/sstream b/libstdc++-v3/include/std/sstream index bb25c2c69a9..bc7d636e702 100644 --- a/libstdc++-v3/include/std/sstream +++ b/libstdc++-v3/include/std/sstream @@ -425,6 +425,7 @@ _GLIBCXX_BEGIN_NAMESPACE_CXX11 // This might not be the same character as _M_string.end() because // basic_stringbuf::overflow might have written to unused capacity // in _M_string without updating its length. + __attribute__((__always_inline__)) char_type* _M_high_mark() const _GLIBCXX_NOEXCEPT {
reply other threads:[~2022-06-08 15:53 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220608155303.83325385087C@sourceware.org \ --to=redi@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ --cc=libstdc++-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).