public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc(refs/users/aoliva/heads/testme)] libstdc++-v3: testsuite: complex proj requirements
@ 2022-06-21  0:08 Alexandre Oliva
  0 siblings, 0 replies; 3+ messages in thread
From: Alexandre Oliva @ 2022-06-21  0:08 UTC (permalink / raw)
  To: gcc-cvs, libstdc++-cvs

https://gcc.gnu.org/g:526b435426b7ebddd411ccf4d1ed1051b6608fe6

commit 526b435426b7ebddd411ccf4d1ed1051b6608fe6
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Mon Jun 20 19:43:55 2022 -0300

    libstdc++-v3: testsuite: complex proj requirements
    
    The template version of complex::proj returns its argument without
    testing for infinities, and that's all we have when neither C99
    complex nor C99 math functions are available, and it seems too hard to
    do better without isinf and copysign.
    
    I suppose just calling them and expecting users will supply
    specializations as needed has been ruled out, and so has refraining
    from defining it when it can't be implemented correctly.
    
    It's pointless to run the proj.cc test under these circumstances, so
    arrange for it to be skipped.  In an unusual way, after trying to
    introduce dg-require tests for ccomplex-or-cmath, and found their
    results to be misleading due to variations across -std=* versions.
    
    
    for  libstdc++-v3/ChangeLog
    
            * testsuite/26_numerics/complex/proj.cc: Skip test in the
            circumstances in which the implementation of proj is known to
            be broken.
    
    TN: V527-032

Diff:
---
 libstdc++-v3/testsuite/26_numerics/complex/proj.cc | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/libstdc++-v3/testsuite/26_numerics/complex/proj.cc b/libstdc++-v3/testsuite/26_numerics/complex/proj.cc
index a053119197c..69f8153c06f 100644
--- a/libstdc++-v3/testsuite/26_numerics/complex/proj.cc
+++ b/libstdc++-v3/testsuite/26_numerics/complex/proj.cc
@@ -397,6 +397,19 @@ test03()
 int
 main()
 {
+  /* If neither of these macros is nonzero, proj calls a
+     specialization of the __complex_proj template, that just returns
+     its argument, without testing for infinities, rendering the whole
+     test pointless, and failing (as intended/noted in the
+     implementation) the cases that involve infinities.  Alas, the
+     normal ways to skip tests may not work: we don't have a test for
+     C99_COMPLEX, and these macros may vary depending on -std=*, but
+     macro tests wouldn't take them into account.  */
+#if ! (_GLIBCXX_USE_C99_COMPLEX || _GLIBCXX_USE_C99_MATH_TR1)
+  if (true)
+    return 0;
+#endif
+
   test01();
   test02();
   test03();


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [gcc(refs/users/aoliva/heads/testme)] libstdc++-v3: testsuite: complex proj requirements
@ 2022-06-22  5:22 Alexandre Oliva
  0 siblings, 0 replies; 3+ messages in thread
From: Alexandre Oliva @ 2022-06-22  5:22 UTC (permalink / raw)
  To: gcc-cvs, libstdc++-cvs

https://gcc.gnu.org/g:34009a5833943c663c3cf1b9cf6cb7ee396f8cbb

commit 34009a5833943c663c3cf1b9cf6cb7ee396f8cbb
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Mon Jun 20 19:43:55 2022 -0300

    libstdc++-v3: testsuite: complex proj requirements
    
    The template version of complex::proj returns its argument without
    testing for infinities, and that's all we have when neither C99
    complex nor C99 math functions are available, and it seems too hard to
    do better without isinf and copysign.
    
    I suppose just calling them and expecting users will supply
    specializations as needed has been ruled out, and so has refraining
    from defining it when it can't be implemented correctly.
    
    It's pointless to run the proj.cc test under these circumstances, so
    arrange for it to be skipped.  In an unusual way, after trying to
    introduce dg-require tests for ccomplex-or-cmath, and found their
    results to be misleading due to variations across -std=* versions.
    
    
    for  libstdc++-v3/ChangeLog
    
            * testsuite/26_numerics/complex/proj.cc: Skip test in the
            circumstances in which the implementation of proj is known to
            be broken.

Diff:
---
 libstdc++-v3/testsuite/26_numerics/complex/proj.cc | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/libstdc++-v3/testsuite/26_numerics/complex/proj.cc b/libstdc++-v3/testsuite/26_numerics/complex/proj.cc
index a053119197c..69f8153c06f 100644
--- a/libstdc++-v3/testsuite/26_numerics/complex/proj.cc
+++ b/libstdc++-v3/testsuite/26_numerics/complex/proj.cc
@@ -397,6 +397,19 @@ test03()
 int
 main()
 {
+  /* If neither of these macros is nonzero, proj calls a
+     specialization of the __complex_proj template, that just returns
+     its argument, without testing for infinities, rendering the whole
+     test pointless, and failing (as intended/noted in the
+     implementation) the cases that involve infinities.  Alas, the
+     normal ways to skip tests may not work: we don't have a test for
+     C99_COMPLEX, and these macros may vary depending on -std=*, but
+     macro tests wouldn't take them into account.  */
+#if ! (_GLIBCXX_USE_C99_COMPLEX || _GLIBCXX_USE_C99_MATH_TR1)
+  if (true)
+    return 0;
+#endif
+
   test01();
   test02();
   test03();


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [gcc(refs/users/aoliva/heads/testme)] libstdc++-v3: testsuite: complex proj requirements
@ 2022-06-21  0:15 Alexandre Oliva
  0 siblings, 0 replies; 3+ messages in thread
From: Alexandre Oliva @ 2022-06-21  0:15 UTC (permalink / raw)
  To: gcc-cvs, libstdc++-cvs

https://gcc.gnu.org/g:ded02367642c2bf33632b0f286cfb454daa3226c

commit ded02367642c2bf33632b0f286cfb454daa3226c
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Mon Jun 20 19:43:55 2022 -0300

    libstdc++-v3: testsuite: complex proj requirements
    
    The template version of complex::proj returns its argument without
    testing for infinities, and that's all we have when neither C99
    complex nor C99 math functions are available, and it seems too hard to
    do better without isinf and copysign.
    
    I suppose just calling them and expecting users will supply
    specializations as needed has been ruled out, and so has refraining
    from defining it when it can't be implemented correctly.
    
    It's pointless to run the proj.cc test under these circumstances, so
    arrange for it to be skipped.  In an unusual way, after trying to
    introduce dg-require tests for ccomplex-or-cmath, and found their
    results to be misleading due to variations across -std=* versions.
    
    
    for  libstdc++-v3/ChangeLog
    
            * testsuite/26_numerics/complex/proj.cc: Skip test in the
            circumstances in which the implementation of proj is known to
            be broken.

Diff:
---
 libstdc++-v3/testsuite/26_numerics/complex/proj.cc | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/libstdc++-v3/testsuite/26_numerics/complex/proj.cc b/libstdc++-v3/testsuite/26_numerics/complex/proj.cc
index a053119197c..69f8153c06f 100644
--- a/libstdc++-v3/testsuite/26_numerics/complex/proj.cc
+++ b/libstdc++-v3/testsuite/26_numerics/complex/proj.cc
@@ -397,6 +397,19 @@ test03()
 int
 main()
 {
+  /* If neither of these macros is nonzero, proj calls a
+     specialization of the __complex_proj template, that just returns
+     its argument, without testing for infinities, rendering the whole
+     test pointless, and failing (as intended/noted in the
+     implementation) the cases that involve infinities.  Alas, the
+     normal ways to skip tests may not work: we don't have a test for
+     C99_COMPLEX, and these macros may vary depending on -std=*, but
+     macro tests wouldn't take them into account.  */
+#if ! (_GLIBCXX_USE_C99_COMPLEX || _GLIBCXX_USE_C99_MATH_TR1)
+  if (true)
+    return 0;
+#endif
+
   test01();
   test02();
   test03();


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-06-22  5:22 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-21  0:08 [gcc(refs/users/aoliva/heads/testme)] libstdc++-v3: testsuite: complex proj requirements Alexandre Oliva
2022-06-21  0:15 Alexandre Oliva
2022-06-22  5:22 Alexandre Oliva

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).