public inbox for libstdc++-cvs@sourceware.org help / color / mirror / Atom feed
From: Alexandre Oliva <aoliva@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc(refs/users/aoliva/heads/testme)] libstdc++: testsuite: tolerate non-cancelling sleep Date: Tue, 21 Jun 2022 00:09:27 +0000 (GMT) [thread overview] Message-ID: <20220621000927.19D0F384144D@sourceware.org> (raw) https://gcc.gnu.org/g:33d2224151a47048e08b0db51a8e718c1889c715 commit 33d2224151a47048e08b0db51a8e718c1889c715 Author: Alexandre Oliva <oliva@adacore.com> Date: Mon Jun 20 20:44:07 2022 -0300 libstdc++: testsuite: tolerate non-cancelling sleep Though sleep, nanosleep and clock_nanosleep are all POSIX cancellation points, not all target systems follow this POSIX requirement. 30_threads/thread/native_handle/cancel.cc will run until it times out on such systems. Rather than failing a C++ library test because of a limitation of the target system, this patch gives the test a chance to successfully exercise the features it intends to exercise, by introducing a cancellation point in a loop that would otherwise run indefinitely on systems exhibiting this limitation. for libstdc++-v3/ChangeLog * testsuite/30_threads/thread/native_handle/cancel.cc: Add an explicit cancellation point in case sleep_for lacks one. TN: V608-051 Diff: --- libstdc++-v3/testsuite/30_threads/thread/native_handle/cancel.cc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libstdc++-v3/testsuite/30_threads/thread/native_handle/cancel.cc b/libstdc++-v3/testsuite/30_threads/thread/native_handle/cancel.cc index dca162b3ace..3cef97e8c53 100644 --- a/libstdc++-v3/testsuite/30_threads/thread/native_handle/cancel.cc +++ b/libstdc++-v3/testsuite/30_threads/thread/native_handle/cancel.cc @@ -30,7 +30,11 @@ void f(std::atomic<bool>& started) { started = true; while (true) - std::this_thread::sleep_for(std::chrono::milliseconds(100)); + { + std::this_thread::sleep_for(std::chrono::milliseconds(100)); + // In case the target system doesn't make sleep a cancellation point... + pthread_testcancel(); + } } int main()
next reply other threads:[~2022-06-21 0:09 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-21 0:09 Alexandre Oliva [this message] 2022-06-21 0:17 Alexandre Oliva 2022-06-22 5:22 Alexandre Oliva 2022-06-23 5:10 Alexandre Oliva
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220621000927.19D0F384144D@sourceware.org \ --to=aoliva@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ --cc=libstdc++-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).