public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
From: Alexandre Oliva <aoliva@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org
Subject: [gcc(refs/users/aoliva/heads/testme)] libstdc++: 60241.cc: tolerate slightly shorter aggregate sleep
Date: Tue, 21 Jun 2022 00:09:32 +0000 (GMT)	[thread overview]
Message-ID: <20220621000932.2B1F5386F41B@sourceware.org> (raw)

https://gcc.gnu.org/g:6db4e87608c136dea82c605deb795cc9c94de2d5

commit 6db4e87608c136dea82c605deb795cc9c94de2d5
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Mon Jun 20 20:44:10 2022 -0300

    libstdc++: 60241.cc: tolerate slightly shorter aggregate sleep
    
    On rtems under qemu, the frequently-interrupted nanosleep ends up
    sleeping shorter than expected, by a margin of less than 0,3%.
    
    I figured failing the library test over a system (emulator?) bug is
    undesirable, so I put in some tolerance for the drift.
    
    
    for  libstdc++-v3/ChangeLog
    
            * testsuite/30_threads/this_thread/60421.cc: Tolerate a
            slightly early wakeup.
    
    TN: V608-049

Diff:
---
 libstdc++-v3/testsuite/30_threads/this_thread/60421.cc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/libstdc++-v3/testsuite/30_threads/this_thread/60421.cc b/libstdc++-v3/testsuite/30_threads/this_thread/60421.cc
index 12dbeba1cc4..f3a5af453c4 100644
--- a/libstdc++-v3/testsuite/30_threads/this_thread/60421.cc
+++ b/libstdc++-v3/testsuite/30_threads/this_thread/60421.cc
@@ -51,9 +51,10 @@ test02()
   std::thread t([&result, &sleeping] {
     auto start = std::chrono::system_clock::now();
     auto time = std::chrono::seconds(3);
+    auto tolerance = std::chrono::milliseconds(10);
     sleeping = true;
     std::this_thread::sleep_for(time);
-    result = std::chrono::system_clock::now() >= (start + time);
+    result = std::chrono::system_clock::now() + tolerance >= (start + time);
     sleeping = false;
   });
   while (!sleeping)


             reply	other threads:[~2022-06-21  0:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-21  0:09 Alexandre Oliva [this message]
2022-06-21  0:17 Alexandre Oliva
2022-06-22  5:22 Alexandre Oliva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220621000932.2B1F5386F41B@sourceware.org \
    --to=aoliva@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    --cc=libstdc++-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).