public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
From: Alexandre Oliva <aoliva@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org
Subject: [gcc(refs/users/aoliva/heads/testme)] libstdc++: eh_globals: gthreads: reset _S_init before deleting key
Date: Tue, 21 Jun 2022 00:16:33 +0000 (GMT)	[thread overview]
Message-ID: <20220621001633.DE8373841464@sourceware.org> (raw)

https://gcc.gnu.org/g:9118254e4ebff9bd11a83549589c02d0e0de3ef4

commit 9118254e4ebff9bd11a83549589c02d0e0de3ef4
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Mon Jun 20 19:45:08 2022 -0300

    libstdc++: eh_globals: gthreads: reset _S_init before deleting key
    
    Clear __eh_globals_init's _S_init in the dtor before deleting the
    gthread key.
    
    This ensures that, in case any code involved in deleting the key
    interacts with eh_globals, the key that is being deleted won't be
    used, and the non-thread-specific eh_globals fallback will.
    
    
    for  libstdc++-v3/ChangeLog
    
            * libsupc++/eh_globals.cc [!_GLIBCXX_HAVE_TLS]
            (__eh_globals_init::~__eh_globals_init): Clear _S_init first.

Diff:
---
 libstdc++-v3/libsupc++/eh_globals.cc | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/libstdc++-v3/libsupc++/eh_globals.cc b/libstdc++-v3/libsupc++/eh_globals.cc
index 768425c0f40..0aadb692a96 100644
--- a/libstdc++-v3/libsupc++/eh_globals.cc
+++ b/libstdc++-v3/libsupc++/eh_globals.cc
@@ -119,8 +119,13 @@ struct __eh_globals_init
   ~__eh_globals_init()
   {
     if (_S_init)
-      __gthread_key_delete(_M_key);
-    _S_init = false;
+      {
+	/* Set it before the call, so that, should
+	   __gthread_key_delete throw an exception, it won't rely on
+	   the key being deleted.  */
+	_S_init = false;
+	__gthread_key_delete(_M_key);
+      }
   }
 
   __eh_globals_init(const __eh_globals_init&) = delete;


             reply	other threads:[~2022-06-21  0:16 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-21  0:16 Alexandre Oliva [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-06-22  0:44 Alexandre Oliva
2022-06-21  0:08 Alexandre Oliva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220621001633.DE8373841464@sourceware.org \
    --to=aoliva@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    --cc=libstdc++-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).