public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-1749] libstdc++: Make __from_chars_alnum_to_val conversion explicit
@ 2022-07-19 13:56 Jonathan Wakely
  0 siblings, 0 replies; only message in thread
From: Jonathan Wakely @ 2022-07-19 13:56 UTC (permalink / raw)
  To: gcc-cvs, libstdc++-cvs

https://gcc.gnu.org/g:20ab3972240aff596a3fa98e9fb09ddc0658fbb3

commit r13-1749-g20ab3972240aff596a3fa98e9fb09ddc0658fbb3
Author: Marco Falke <falke.marco@gmail.com>
Date:   Tue Jul 19 10:10:39 2022 +0100

    libstdc++: Make __from_chars_alnum_to_val conversion explicit
    
    The optimizations from commit r12-8175-ga54137c88061c7 introduced a
    clang integer sanitizer error.
    
    Fix this with an explicit static_cast, similar to the fix for PR 96766.
    
    libstdc++-v3/ChangeLog:
    
            * include/std/charconv (__from_chars_alnum_to_val): Replace
            implicit conversion from int to unsigned char with explicit
            cast.

Diff:
---
 libstdc++-v3/include/std/charconv | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libstdc++-v3/include/std/charconv b/libstdc++-v3/include/std/charconv
index 218813e4797..533320ea085 100644
--- a/libstdc++-v3/include/std/charconv
+++ b/libstdc++-v3/include/std/charconv
@@ -436,7 +436,7 @@ namespace __detail
     __from_chars_alnum_to_val(unsigned char __c)
     {
       if _GLIBCXX17_CONSTEXPR (_DecOnly)
-	return __c - '0';
+	return static_cast<unsigned char>(__c - '0');
       else
 	{
 	  // This initializer is deliberately made dependent in order to work


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-07-19 13:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-19 13:56 [gcc r13-1749] libstdc++: Make __from_chars_alnum_to_val conversion explicit Jonathan Wakely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).