public inbox for libstdc++-cvs@sourceware.org help / color / mirror / Atom feed
From: Jonathan Wakely <redi@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r12-8592] libstdc++: Simplify test by not using std::log2 Date: Thu, 21 Jul 2022 11:16:39 +0000 (GMT) [thread overview] Message-ID: <20220721111639.11FA23857011@sourceware.org> (raw) https://gcc.gnu.org/g:145ef5e2be28183f2b92b1f81b4d75210b524503 commit r12-8592-g145ef5e2be28183f2b92b1f81b4d75210b524503 Author: Jonathan Wakely <jwakely@redhat.com> Date: Thu Jun 23 11:58:16 2022 +0100 libstdc++: Simplify test by not using std::log2 This test uses std::log2 without including <cmath>, but it doesn't need to use it at all. Just get the number of digits from numeric_limits instead. libstdc++-v3/ChangeLog: * testsuite/26_numerics/random/random_device/entropy.cc: Use numeric_limits<unsigned>::digits. (cherry picked from commit 78fd15fd4a641cfac28ce60bf43a3e1ca309537b) Diff: --- libstdc++-v3/testsuite/26_numerics/random/random_device/entropy.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libstdc++-v3/testsuite/26_numerics/random/random_device/entropy.cc b/libstdc++-v3/testsuite/26_numerics/random/random_device/entropy.cc index 63b7043bf9b..9f529f5d814 100644 --- a/libstdc++-v3/testsuite/26_numerics/random/random_device/entropy.cc +++ b/libstdc++-v3/testsuite/26_numerics/random/random_device/entropy.cc @@ -1,6 +1,7 @@ // { dg-do run { target c++11 } } #include <random> +#include <limits> #include <testsuite_hooks.h> #include <testsuite_random.h> @@ -12,7 +13,7 @@ test01() VERIFY( std::random_device(token).entropy() == 0.0 ); using result_type = std::random_device::result_type; - const double max = std::log2(std::numeric_limits<result_type>::max() + 1.0); + const double max = std::numeric_limits<result_type>::digits; for (auto token : { "/dev/random", "/dev/urandom" }) if (__gnu_test::random_device_available(token))
reply other threads:[~2022-07-21 11:16 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220721111639.11FA23857011@sourceware.org \ --to=redi@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ --cc=libstdc++-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).