From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1851) id 12555385AE68; Thu, 28 Jul 2022 12:10:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 12555385AE68 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Martin Liska To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc/devel/sphinx] libstdc++: Minor codegen improvement for atomic wait spinloop X-Act-Checkin: gcc X-Git-Author: Thomas Rodgers X-Git-Refname: refs/heads/devel/sphinx X-Git-Oldrev: 4aa2b803c18542f76d565f77508e8fab12d66feb X-Git-Newrev: f0b75c239b45d7c48b6b9d76a3efa048ae10118b Message-Id: <20220728121013.12555385AE68@sourceware.org> Date: Thu, 28 Jul 2022 12:10:13 +0000 (GMT) X-BeenThere: libstdc++-cvs@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++-cvs mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Jul 2022 12:10:13 -0000 https://gcc.gnu.org/g:f0b75c239b45d7c48b6b9d76a3efa048ae10118b commit f0b75c239b45d7c48b6b9d76a3efa048ae10118b Author: Thomas Rodgers Date: Tue Jul 5 17:42:42 2022 -0700 libstdc++: Minor codegen improvement for atomic wait spinloop This patch merges the spin loops in the atomic wait implementation which is a minor codegen improvement. libstdc++-v3/ChangeLog: * include/bits/atomic_wait.h (__atomic_spin): Merge spin loops. Diff: --- libstdc++-v3/include/bits/atomic_wait.h | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/libstdc++-v3/include/bits/atomic_wait.h b/libstdc++-v3/include/bits/atomic_wait.h index 125b1cad886..a6d55d3af8a 100644 --- a/libstdc++-v3/include/bits/atomic_wait.h +++ b/libstdc++-v3/include/bits/atomic_wait.h @@ -142,8 +142,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION #endif } - constexpr auto __atomic_spin_count_1 = 12; - constexpr auto __atomic_spin_count_2 = 4; + constexpr auto __atomic_spin_count_relax = 12; + constexpr auto __atomic_spin_count = 16; struct __default_spin_policy { @@ -157,18 +157,15 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION bool __atomic_spin(_Pred& __pred, _Spin __spin = _Spin{ }) noexcept { - for (auto __i = 0; __i < __atomic_spin_count_1; ++__i) + for (auto __i = 0; __i < __atomic_spin_count; ++__i) { if (__pred()) return true; - __detail::__thread_relax(); - } - for (auto __i = 0; __i < __atomic_spin_count_2; ++__i) - { - if (__pred()) - return true; - __detail::__thread_yield(); + if (__i < __atomic_spin_count_relax) + __detail::__thread_relax(); + else + __detail::__thread_yield(); } while (__spin())