public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jonathan Wakely <redi@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org
Subject: [gcc r12-8848] libstdc++: eh_globals: gthreads: reset _S_init before deleting key
Date: Wed, 19 Oct 2022 20:29:22 +0000 (GMT)	[thread overview]
Message-ID: <20221019202922.ACB4C3858C83@sourceware.org> (raw)

https://gcc.gnu.org/g:362e56d042f2d37337eea50b97b993f5ac6db86d

commit r12-8848-g362e56d042f2d37337eea50b97b993f5ac6db86d
Author: Alexandre Oliva <oliva@adacore.com>
Date:   Tue Jun 21 23:11:02 2022 -0300

    libstdc++: eh_globals: gthreads: reset _S_init before deleting key
    
    Clear __eh_globals_init's _S_init in the dtor before deleting the
    gthread key.
    
    This ensures that, in case any code involved in deleting the key
    interacts with eh_globals, the key that is being deleted won't be
    used, and the non-thread-specific eh_globals fallback will.
    
    for  libstdc++-v3/ChangeLog
    
            * libsupc++/eh_globals.cc [!_GLIBCXX_HAVE_TLS]
            (__eh_globals_init::~__eh_globals_init): Clear _S_init first.
    
    (cherry picked from commit a33dda016e5acf9c6325ce8a72a1b0238130374e)

Diff:
---
 libstdc++-v3/libsupc++/eh_globals.cc | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/libstdc++-v3/libsupc++/eh_globals.cc b/libstdc++-v3/libsupc++/eh_globals.cc
index 768425c0f40..0aadb692a96 100644
--- a/libstdc++-v3/libsupc++/eh_globals.cc
+++ b/libstdc++-v3/libsupc++/eh_globals.cc
@@ -119,8 +119,13 @@ struct __eh_globals_init
   ~__eh_globals_init()
   {
     if (_S_init)
-      __gthread_key_delete(_M_key);
-    _S_init = false;
+      {
+	/* Set it before the call, so that, should
+	   __gthread_key_delete throw an exception, it won't rely on
+	   the key being deleted.  */
+	_S_init = false;
+	__gthread_key_delete(_M_key);
+      }
   }
 
   __eh_globals_init(const __eh_globals_init&) = delete;

                 reply	other threads:[~2022-10-19 20:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221019202922.ACB4C3858C83@sourceware.org \
    --to=redi@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    --cc=libstdc++-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).