public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org
Subject: [gcc r13-3932] libstdc++: Fix up to_chars ppc64le _Float128 overloads [PR107636]
Date: Sat, 12 Nov 2022 20:57:23 +0000 (GMT)	[thread overview]
Message-ID: <20221112205723.E7B993858407@sourceware.org> (raw)

https://gcc.gnu.org/g:ec6c2029714057b4bca344ee59be977d17361092

commit r13-3932-gec6c2029714057b4bca344ee59be977d17361092
Author: Jakub Jelinek <jakub@redhat.com>
Date:   Sat Nov 12 21:56:47 2022 +0100

    libstdc++: Fix up to_chars ppc64le _Float128 overloads [PR107636]
    
    As reported, I've misplaced __extension__ keywords in these cases
    (wanted not to have them on the whole inlines because _Float128 is
    completely standard now while __float128 is not, but before return
    it is a syntax error.
    I've verified on a short testcase that both g++ and clang++ accept
    __extension__ after return keyword.
    
    2022-11-12  Jakub Jelinek  <jakub@redhat.com>
    
            PR libstdc++/107636
            * include/std/charconv (to_chars): Fix up powerpc64le _Float128
            overload __extension__ placement.

Diff:
---
 libstdc++-v3/include/std/charconv | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/libstdc++-v3/include/std/charconv b/libstdc++-v3/include/std/charconv
index acad865f8aa..c5ed6fac73b 100644
--- a/libstdc++-v3/include/std/charconv
+++ b/libstdc++-v3/include/std/charconv
@@ -892,23 +892,25 @@ namespace __detail
   inline to_chars_result
   to_chars(char* __first, char* __last, _Float128 __value) noexcept
   {
-    __extension__
-    return to_chars(__first, __last, static_cast<__float128>(__value));
+    return __extension__ to_chars(__first, __last,
+				  static_cast<__float128>(__value));
   }
   inline to_chars_result
   to_chars(char* __first, char* __last, _Float128 __value,
 	   chars_format __fmt) noexcept
   {
-    __extension__
-    return to_chars(__first, __last, static_cast<__float128>(__value), __fmt);
+
+    return __extension__ to_chars(__first, __last,
+				  static_cast<__float128>(__value), __fmt);
   }
   inline to_chars_result
   to_chars(char* __first, char* __last, _Float128 __value,
 	   chars_format __fmt, int __precision) noexcept
   {
-    __extension__
-    return to_chars(__first, __last, static_cast<__float128>(__value), __fmt,
-		    __precision);
+
+    return __extension__ to_chars(__first, __last,
+				  static_cast<__float128>(__value), __fmt,
+				  __precision);
   }
 #else
   to_chars_result to_chars(char* __first, char* __last, _Float128 __value)

                 reply	other threads:[~2022-11-12 20:57 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221112205723.E7B993858407@sourceware.org \
    --to=jakub@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    --cc=libstdc++-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).