public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r13-4228] libstdc++: Fix pool resource build errors for H8 [PR107801]
@ 2022-11-22 10:39 Jonathan Wakely
  0 siblings, 0 replies; only message in thread
From: Jonathan Wakely @ 2022-11-22 10:39 UTC (permalink / raw)
  To: gcc-cvs, libstdc++-cvs

https://gcc.gnu.org/g:0f9659e770304d3c44cfa0e793833a461bc487aa

commit r13-4228-g0f9659e770304d3c44cfa0e793833a461bc487aa
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Tue Nov 22 09:53:36 2022 +0000

    libstdc++: Fix pool resource build errors for H8 [PR107801]
    
    The array of pool sizes was previously adjusted to work for msp430-elf
    which has 16-bit int and either 16-bit size_t or 20-bit size_t. The
    largest pool sizes were disabled unless size_t has more than 20 bits.
    
    The H8 family has 16-bit int but 32-bit size_t, which means that the
    largest sizes are enabled, but 1<<15 produces a negative number that
    then cannot be narrowed to size_t.
    
    Replace the test for 32-bit size_t with a test for 32-bit int, which
    means we won't use the 4kiB to 4MiB pools for targets with 16-bit int
    even if they have a wider size_t.
    
    libstdc++-v3/ChangeLog:
    
            PR libstdc++/107801
            * src/c++17/memory_resource.cc (pool_sizes): Disable large pools
            for targets with 16-bit int.

Diff:
---
 libstdc++-v3/src/c++17/memory_resource.cc | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/libstdc++-v3/src/c++17/memory_resource.cc b/libstdc++-v3/src/c++17/memory_resource.cc
index 651d07489aa..0bd94dbc6a7 100644
--- a/libstdc++-v3/src/c++17/memory_resource.cc
+++ b/libstdc++-v3/src/c++17/memory_resource.cc
@@ -873,9 +873,11 @@ namespace pmr
       256, 320, 384, 448,
       512, 768,
 #if __SIZE_WIDTH__ > 16
+      // Use bigger pools if size_t has at least 20 bits.
       1024, 1536,
       2048, 3072,
-#if __SIZE_WIDTH__ > 20
+#if __INT_WIDTH__ >= 32
+      // Use even bigger pools if int has at least 32 bits.
       1<<12, 1<<13, 1<<14,
       1<<15, 1<<16, 1<<17,
       1<<20, 1<<21, 1<<22 // 4MB should be enough for anybody

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2022-11-22 10:39 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-22 10:39 [gcc r13-4228] libstdc++: Fix pool resource build errors for H8 [PR107801] Jonathan Wakely

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).