public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
* [gcc r12-8934] libstdc++: Fix dangling reference in filesystem::path::filename()
@ 2022-11-24 16:36 Jonathan Wakely
0 siblings, 0 replies; only message in thread
From: Jonathan Wakely @ 2022-11-24 16:36 UTC (permalink / raw)
To: gcc-cvs, libstdc++-cvs
https://gcc.gnu.org/g:6e3b2c0d5e676e1cba1c27b95dd850e5cc33f9e1
commit r12-8934-g6e3b2c0d5e676e1cba1c27b95dd850e5cc33f9e1
Author: Jonathan Wakely <jwakely@redhat.com>
Date: Fri Oct 28 15:28:09 2022 +0100
libstdc++: Fix dangling reference in filesystem::path::filename()
The new -Wdangling-reference warning noticed this.
libstdc++-v3/ChangeLog:
* include/bits/fs_path.h (path::filename()): Fix dangling
reference.
(cherry picked from commit 49237fe6ef677a81eae701f937546210c90b5914)
Diff:
---
libstdc++-v3/include/bits/fs_path.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libstdc++-v3/include/bits/fs_path.h b/libstdc++-v3/include/bits/fs_path.h
index 1b4a1b69f37..7a3d0513134 100644
--- a/libstdc++-v3/include/bits/fs_path.h
+++ b/libstdc++-v3/include/bits/fs_path.h
@@ -1288,9 +1288,9 @@ namespace __detail
{
if (_M_pathname.back() == preferred_separator)
return {};
- auto& __last = *--end();
- if (__last._M_type() == _Type::_Filename)
- return __last;
+ auto __last = --end();
+ if (__last->_M_type() == _Type::_Filename)
+ return *__last;
}
return {};
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-11-24 16:36 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-24 16:36 [gcc r12-8934] libstdc++: Fix dangling reference in filesystem::path::filename() Jonathan Wakely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).