From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2181) id 195943858D1E; Thu, 22 Dec 2022 10:15:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 195943858D1E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1671704105; bh=WuSU2bCk/f5ae4ieWp1c7ioMHF0VsaL2Qd77CxPjrIc=; h=From:To:Subject:Date:From; b=oy3uIYXneBccdOY+kn426q72L/HKD4vzypFIn72rHn4P59cUhER8AqyC3MOCjHfuW KYKZpjVQOhGGqCz6+7cuIf2qrnqf1uDflvEwxCHyPQn6ZCC+dkYh8GRU0Yt10Ql6Pe 9mElcL0C4V339Fve0p/mWPcyq2gClrbZ+OqUVbW0= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jonathan Wakely To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r13-4840] libstdc++: Add [[nodiscard]] in X-Act-Checkin: gcc X-Git-Author: Jonathan Wakely X-Git-Refname: refs/heads/master X-Git-Oldrev: eef81eefcdc2a58111e50eb2162ea1f5becc8004 X-Git-Newrev: ec8f914f572ce45dbf5743c801c6a101e9a785c7 Message-Id: <20221222101505.195943858D1E@sourceware.org> Date: Thu, 22 Dec 2022 10:15:05 +0000 (GMT) List-Id: https://gcc.gnu.org/g:ec8f914f572ce45dbf5743c801c6a101e9a785c7 commit r13-4840-gec8f914f572ce45dbf5743c801c6a101e9a785c7 Author: Jonathan Wakely Date: Thu Dec 22 00:19:45 2022 +0000 libstdc++: Add [[nodiscard]] in libstdc++-v3/ChangeLog: * include/std/chrono: Use nodiscard attribute. Diff: --- libstdc++-v3/include/std/chrono | 46 ++++++++++++++++++++++++++--------------- 1 file changed, 29 insertions(+), 17 deletions(-) diff --git a/libstdc++-v3/include/std/chrono b/libstdc++-v3/include/std/chrono index 4c5fbfaeb83..33653f8efb1 100644 --- a/libstdc++-v3/include/std/chrono +++ b/libstdc++-v3/include/std/chrono @@ -128,11 +128,13 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION using time_point = chrono::time_point; static constexpr bool is_steady = false; + [[nodiscard]] static time_point now() { return from_sys(system_clock::now()); } template + [[nodiscard]] static sys_time> to_sys(const utc_time<_Duration>& __t) { @@ -145,6 +147,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION } template + [[nodiscard]] static utc_time> from_sys(const sys_time<_Duration>& __t) { @@ -171,11 +174,13 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION static constexpr bool is_steady = false; // XXX true for CLOCK_TAI? // TODO move into lib, use CLOCK_TAI on linux, add extension point. + [[nodiscard]] static time_point now() { return from_utc(utc_clock::now()); } template + [[nodiscard]] static utc_time> to_utc(const tai_time<_Duration>& __t) { @@ -184,6 +189,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION } template + [[nodiscard]] static tai_time> from_utc(const utc_time<_Duration>& __t) { @@ -208,11 +214,13 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION static constexpr bool is_steady = false; // XXX // TODO move into lib, add extension point. + [[nodiscard]] static time_point now() { return from_utc(utc_clock::now()); } template + [[nodiscard]] static utc_time> to_utc(const gps_time<_Duration>& __t) { @@ -221,6 +229,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION } template + [[nodiscard]] static gps_time> from_utc(const utc_time<_Duration>& __t) { @@ -394,6 +403,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION /// Convert a time point to a different clock. template + [[nodiscard]] inline auto clock_cast(const time_point<_SourceClock, _Duration>& __t) requires __detail::__clock_convs<_DestClock, _SourceClock, _Duration> @@ -2620,6 +2630,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION leap_second(const leap_second&) = default; leap_second& operator=(const leap_second&) = default; + [[nodiscard]] constexpr sys_seconds date() const noexcept { @@ -2628,6 +2639,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION return sys_seconds(-_M_s); } + [[nodiscard]] constexpr seconds value() const noexcept { @@ -2638,71 +2650,71 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION // This can be defaulted because the database will never contain two // leap_second objects with the same date but different signs. - friend constexpr bool + [[nodiscard]] friend constexpr bool operator==(const leap_second&, const leap_second&) noexcept = default; - friend constexpr strong_ordering + [[nodiscard]] friend constexpr strong_ordering operator<=>(const leap_second& __x, const leap_second& __y) noexcept { return __x.date() <=> __y.date(); } template - friend constexpr bool + [[nodiscard]] friend constexpr bool operator==(const leap_second& __x, const sys_time<_Duration>& __y) noexcept { return __x.date() == __y; } template - friend constexpr bool + [[nodiscard]] friend constexpr bool operator<(const leap_second& __x, const sys_time<_Duration>& __y) noexcept { return __x.date() < __y; } template - friend constexpr bool + [[nodiscard]] friend constexpr bool operator<(const sys_time<_Duration>& __x, const leap_second& __y) noexcept { return __x < __y.date(); } template - friend constexpr bool + [[nodiscard]] friend constexpr bool operator>(const leap_second& __x, const sys_time<_Duration>& __y) noexcept { return __y < __x.date(); } template - friend constexpr bool + [[nodiscard]] friend constexpr bool operator>(const sys_time<_Duration>& __x, const leap_second& __y) noexcept { return __y.date() < __x; } template - friend constexpr bool + [[nodiscard]] friend constexpr bool operator<=(const leap_second& __x, - const sys_time<_Duration>& __y) noexcept + const sys_time<_Duration>& __y) noexcept { return !(__y < __x.date()); } template - friend constexpr bool + [[nodiscard]] friend constexpr bool operator<=(const sys_time<_Duration>& __x, - const leap_second& __y) noexcept + const leap_second& __y) noexcept { return !(__y.date() < __x); } template - friend constexpr bool + [[nodiscard]] friend constexpr bool operator>=(const leap_second& __x, - const sys_time<_Duration>& __y) noexcept + const sys_time<_Duration>& __y) noexcept { return !(__x.date() < __y); } template - friend constexpr bool + [[nodiscard]] friend constexpr bool operator>=(const sys_time<_Duration>& __x, - const leap_second& __y) noexcept + const leap_second& __y) noexcept { return !(__x < __y.date()); } template _Duration> - friend constexpr auto + [[nodiscard]] friend constexpr auto operator<=>(const leap_second& __x, - const sys_time<_Duration>& __y) noexcept + const sys_time<_Duration>& __y) noexcept { return __x.date() <=> __y; } private: