public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jonathan Wakely <redi@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org
Subject: [gcc r13-4871] libstdc++: Remove problematic static_assert from src/c++20/tzdb.cc
Date: Fri, 23 Dec 2022 09:44:07 +0000 (GMT)	[thread overview]
Message-ID: <20221223094407.8F25C3858D1E@sourceware.org> (raw)

https://gcc.gnu.org/g:db3c5831f80e674b9ee77c1e9ca8364a72ca5758

commit r13-4871-gdb3c5831f80e674b9ee77c1e9ca8364a72ca5758
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Fri Dec 23 09:19:38 2022 +0000

    libstdc++: Remove problematic static_assert from src/c++20/tzdb.cc
    
    This assertion fails for cris-elf where sizeof(datetime) is only 7, due
    to lower alignment requirements. The assertion was used while I was
    writing the code to check that the objects were as compact as I wanted,
    but it doesn't need to be kept now.
    
    libstdc++-v3/ChangeLog:
    
            * src/c++20/tzdb.cc: Remove static_assert.

Diff:
---
 libstdc++-v3/src/c++20/tzdb.cc | 1 -
 1 file changed, 1 deletion(-)

diff --git a/libstdc++-v3/src/c++20/tzdb.cc b/libstdc++-v3/src/c++20/tzdb.cc
index a0bb03173a9..a02bcd4aec7 100644
--- a/libstdc++-v3/src/c++20/tzdb.cc
+++ b/libstdc++-v3/src/c++20/tzdb.cc
@@ -448,7 +448,6 @@ namespace std::chrono
       // This allows on_day to reuse padding of at_time.
       // This keeps the size to 8 bytes and the alignment to 4 bytes.
       struct datetime : at_time { on_day day; };
-      static_assert(sizeof(datetime) == 8 && alignof(datetime) == 4);
 
       // TODO combining name+letters into a single string (like in ZoneInfo)
       // would save sizeof(string) and make Rule fit in a single cacheline.

                 reply	other threads:[~2022-12-23  9:44 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221223094407.8F25C3858D1E@sourceware.org \
    --to=redi@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    --cc=libstdc++-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).