public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jonathan Wakely <redi@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org
Subject: [gcc r13-5079] libstdc++: Fix std::span constraint for sizeof(size_t) < sizeof(int) [PR108221]
Date: Tue, 10 Jan 2023 10:10:04 +0000 (GMT)	[thread overview]
Message-ID: <20230110101004.1963E3858CDA@sourceware.org> (raw)

https://gcc.gnu.org/g:b39f4333d18cc58b1a655c537a78fefe95b82609

commit r13-5079-gb39f4333d18cc58b1a655c537a78fefe95b82609
Author: Jonathan Wakely <jwakely@redhat.com>
Date:   Mon Jan 9 10:45:31 2023 +0000

    libstdc++: Fix std::span constraint for sizeof(size_t) < sizeof(int) [PR108221]
    
    The default constructor has a constraint that is always false if
    arithmetic on size_t values promotes to int. Rewrite the constraint
    exactly as written in the standard, which works correctly.
    
    libstdc++-v3/ChangeLog:
    
            PR libstdc++/108221
            * include/std/span (span::span()): Un-simplify constraint to
            work for size_t of lesser rank than int.

Diff:
---
 libstdc++-v3/include/std/span | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libstdc++-v3/include/std/span b/libstdc++-v3/include/std/span
index 251fed91abf..b336332b190 100644
--- a/libstdc++-v3/include/std/span
+++ b/libstdc++-v3/include/std/span
@@ -145,7 +145,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
 
       constexpr
       span() noexcept
-      requires ((_Extent + 1u) <= 1u)
+      requires (_Extent == dynamic_extent || _Extent == 0)
       : _M_ptr(nullptr), _M_extent(0)
       { }

                 reply	other threads:[~2023-01-10 10:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230110101004.1963E3858CDA@sourceware.org \
    --to=redi@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    --cc=libstdc++-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).