From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7857) id 6FF4F3858D3C; Tue, 21 Mar 2023 19:39:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6FF4F3858D3C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1679427556; bh=ELcZjjL++TyLiebbNn1M0BbA8w3/4qa3yTeoeCvvVSM=; h=From:To:Subject:Date:From; b=OsestSX4QTaUN3LrrXVHkGlwCKh1qUqBsTP4XrUnzoZ8FcZWlvRvNJJXzYevy7i0a QIU9nO29wqlMLVjLVhDin5g82o9ImaCEqjKRdeb7I9te0HYkBLkyJK/hD0O4zgT31+ LuU/UuQVMfy1DKWDjv2jP9v/meBzKB5AXZrtzdQ8= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Matthias Kretz To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r12-9305] libstdc++: Skip integer division optimization for Clang X-Act-Checkin: gcc X-Git-Author: Matthias Kretz X-Git-Refname: refs/heads/releases/gcc-12 X-Git-Oldrev: 54f38839fad67b048f3228d88ec90ef1ee6d6893 X-Git-Newrev: 8d91c9dd93861c8ede2e150c60a64c591efa6e25 Message-Id: <20230321193916.6FF4F3858D3C@sourceware.org> Date: Tue, 21 Mar 2023 19:39:16 +0000 (GMT) List-Id: https://gcc.gnu.org/g:8d91c9dd93861c8ede2e150c60a64c591efa6e25 commit r12-9305-g8d91c9dd93861c8ede2e150c60a64c591efa6e25 Author: Matthias Kretz Date: Tue Mar 21 14:20:52 2023 +0100 libstdc++: Skip integer division optimization for Clang Clang ICEs on _SimdImplX86::_S_divides. The function is only working around a missed optimization and not necessary for correctness. Therefore, don't use it for Clang. Signed-off-by: Matthias Kretz libstdc++-v3/ChangeLog: * include/experimental/bits/simd_detail.h: Don't define _GLIBCXX_SIMD_WORKAROUND_PR90993 for Clang. * include/experimental/bits/simd_x86.h (_S_divides): Remove check for __clang__. (cherry picked from commit 403e48ef441b0502af46ad3598f699f4a1611791) Diff: --- libstdc++-v3/include/experimental/bits/simd_detail.h | 2 ++ libstdc++-v3/include/experimental/bits/simd_x86.h | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libstdc++-v3/include/experimental/bits/simd_detail.h b/libstdc++-v3/include/experimental/bits/simd_detail.h index 9135d3e75d3..de8d018c515 100644 --- a/libstdc++-v3/include/experimental/bits/simd_detail.h +++ b/libstdc++-v3/include/experimental/bits/simd_detail.h @@ -316,7 +316,9 @@ #endif // integer division not optimized +#ifndef __clang__ #define _GLIBCXX_SIMD_WORKAROUND_PR90993 1 +#endif // very bad codegen for extraction and concatenation of 128/256 "subregisters" // with sizeof(element type) < 8: https://godbolt.org/g/mqUsgM diff --git a/libstdc++-v3/include/experimental/bits/simd_x86.h b/libstdc++-v3/include/experimental/bits/simd_x86.h index b9af1ce538c..53e886c5136 100644 --- a/libstdc++-v3/include/experimental/bits/simd_x86.h +++ b/libstdc++-v3/include/experimental/bits/simd_x86.h @@ -1422,7 +1422,7 @@ template }, [&__xf, &__yf](auto __i) -> _SimdWrapper<_Float, __n_intermediate> { -#if !defined __clang__ && __GCC_IEC_559 == 0 +#if __GCC_IEC_559 == 0 // If -freciprocal-math is active, using the `/` operator is // incorrect because it may be translated to an imprecise // multiplication with reciprocal. We need to use inline @@ -1477,7 +1477,7 @@ template */ return _Base::_S_divides(__x, __y); } - #endif // _GLIBCXX_SIMD_WORKAROUND_PR90993 +#endif // _GLIBCXX_SIMD_WORKAROUND_PR90993 // }}} // _S_modulus {{{