From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2181) id 39E3C3858436; Mon, 3 Jul 2023 23:06:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 39E3C3858436 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1688425592; bh=p8kptaIOImSFZf3tDaAO6/zkp1KCm0gPglfv+IY1V1s=; h=From:To:Subject:Date:From; b=EW6syz4llrqnBn/xb7V68sAajsDAIkAO3/VzzPasr8dPgYj1tAEDrTn4ga0ApUoaH 6QAKb6fWc83dXHSJ2F5J4iGtli5bJJSJOBcJ1M5ExO7/PeLBXDarZwXEBX8taJYwbh 92Z1DfN2Zp6EWRadYohrnP3msrs9sRCV621qZduU= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jonathan Wakely To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r14-2272] libstdc++: Qualify calls to std::_Destroy and _Destroy_aux X-Act-Checkin: gcc X-Git-Author: Jonathan Wakely X-Git-Refname: refs/heads/master X-Git-Oldrev: 7c521f6751e47d9dfaca2c8288c65f94e2f54d3d X-Git-Newrev: 33245d6b87a284495304c9952813b6b83d5df99f Message-Id: <20230703230632.39E3C3858436@sourceware.org> Date: Mon, 3 Jul 2023 23:06:32 +0000 (GMT) List-Id: https://gcc.gnu.org/g:33245d6b87a284495304c9952813b6b83d5df99f commit r14-2272-g33245d6b87a284495304c9952813b6b83d5df99f Author: Jonathan Wakely Date: Fri Jun 30 21:09:01 2023 +0100 libstdc++: Qualify calls to std::_Destroy and _Destroy_aux These calls should be qualified to prevent ADL, which can cause errors for incomplete types that are associated classes. libstdc++-v3/ChangeLog: * include/bits/alloc_traits.h (_Destroy): Qualify call. * include/bits/stl_construct.h (_Destroy, _Destroy_n): Likewise. * testsuite/23_containers/vector/cons/destroy-adl.cc: New test. Diff: --- libstdc++-v3/include/bits/alloc_traits.h | 2 +- libstdc++-v3/include/bits/stl_construct.h | 4 ++-- .../testsuite/23_containers/vector/cons/destroy-adl.cc | 11 +++++++++++ 3 files changed, 14 insertions(+), 3 deletions(-) diff --git a/libstdc++-v3/include/bits/alloc_traits.h b/libstdc++-v3/include/bits/alloc_traits.h index cd91d152f64..182c3e23eed 100644 --- a/libstdc++-v3/include/bits/alloc_traits.h +++ b/libstdc++-v3/include/bits/alloc_traits.h @@ -944,7 +944,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION _Destroy(_ForwardIterator __first, _ForwardIterator __last, allocator<_Tp>&) { - _Destroy(__first, __last); + std::_Destroy(__first, __last); } #endif /// @endcond diff --git a/libstdc++-v3/include/bits/stl_construct.h b/libstdc++-v3/include/bits/stl_construct.h index 574f4fa50b4..cf62d927cdb 100644 --- a/libstdc++-v3/include/bits/stl_construct.h +++ b/libstdc++-v3/include/bits/stl_construct.h @@ -190,7 +190,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION #endif #if __cplusplus >= 202002L if (std::__is_constant_evaluated()) - return _Destroy_aux::__destroy(__first, __last); + return std::_Destroy_aux::__destroy(__first, __last); #endif std::_Destroy_aux<__has_trivial_destructor(_Value_type)>:: __destroy(__first, __last); @@ -239,7 +239,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION #endif #if __cplusplus >= 202002L if (std::__is_constant_evaluated()) - return _Destroy_n_aux::__destroy_n(__first, __count); + return std::_Destroy_n_aux::__destroy_n(__first, __count); #endif return std::_Destroy_n_aux<__has_trivial_destructor(_Value_type)>:: __destroy_n(__first, __count); diff --git a/libstdc++-v3/testsuite/23_containers/vector/cons/destroy-adl.cc b/libstdc++-v3/testsuite/23_containers/vector/cons/destroy-adl.cc new file mode 100644 index 00000000000..5623842e9b1 --- /dev/null +++ b/libstdc++-v3/testsuite/23_containers/vector/cons/destroy-adl.cc @@ -0,0 +1,11 @@ +// { dg-do compile } + +#include + +template struct Holder { T t; }; // { dg-bogus "incomplete type" } +struct Incomplete; + +void destroy(std::vector*>* p) +{ + p->~vector(); +}