From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2181) id ECD583856261; Fri, 28 Jul 2023 17:32:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ECD583856261 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1690565545; bh=FBXcgEgDIE3hfsTNp63xogbkzD8KN+NHj4qzSKgAWvg=; h=From:To:Subject:Date:From; b=jc0L3DT84d5q6WNrEnoWGuaDzNMr2T6BCl6SEhq2bRB260olK06VjkPzkqfC4cyxr +51q2n1pLGd9LedFLikEm8chqCDGIXvmX1ioctZku3XRWVTYJme+kVwqJhpR8+7XQB BNUNgKkERVgUYhUjTA4Of5I85MNKaw7yHrqUkM1o= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jonathan Wakely To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r13-7626] libstdc++: Add missing constexpr specifiers in X-Act-Checkin: gcc X-Git-Author: Deev Patel X-Git-Refname: refs/heads/releases/gcc-13 X-Git-Oldrev: 962cd3e2c475e8197fd0cfa7330a8f352b4ff5b2 X-Git-Newrev: 52010f9449a7bf4f9d662e2708df301e85768a15 Message-Id: <20230728173225.ECD583856261@sourceware.org> Date: Fri, 28 Jul 2023 17:32:25 +0000 (GMT) List-Id: https://gcc.gnu.org/g:52010f9449a7bf4f9d662e2708df301e85768a15 commit r13-7626-g52010f9449a7bf4f9d662e2708df301e85768a15 Author: Deev Patel Date: Mon Jul 24 21:10:52 2023 +0100 libstdc++: Add missing constexpr specifiers in A couple of virtual functions in the libstdc++ format header are marked constexpr in the base class, but not in the derived class. This was causing build failures when trying to compile latest gcc libstdc++ with clang 16 using c++20. Adding the constexpr specifier resolves the issue. libstdc++-v3/ChangeLog: * include/std/format (_Formatting_scanner::_M_on_chars): Add missing constexpr specifier. (_Formatting_scanner::_M_format_arg): Likewise. (cherry picked from commit 96482ffe60d9bdec802fcad705c69641b2a3e040) Diff: --- libstdc++-v3/include/std/format | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libstdc++-v3/include/std/format b/libstdc++-v3/include/std/format index 9d5981e4882..9a3896b8339 100644 --- a/libstdc++-v3/include/std/format +++ b/libstdc++-v3/include/std/format @@ -3553,14 +3553,14 @@ namespace __format using iterator = typename _Scanner<_CharT>::iterator; - void + constexpr void _M_on_chars(iterator __last) override { basic_string_view<_CharT> __str(this->begin(), __last); _M_fc.advance_to(__format::__write(_M_fc.out(), __str)); } - void + constexpr void _M_format_arg(size_t __id) override { using _Context = basic_format_context<_Out, _CharT>;