public inbox for libstdc++-cvs@sourceware.org help / color / mirror / Atom feed
From: Jonathan Wakely <redi@gcc.gnu.org> To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r14-3277] libstdc++: Disable PCH for tests that rely on include order Date: Thu, 17 Aug 2023 07:45:10 +0000 (GMT) [thread overview] Message-ID: <20230817074510.16F7E385558A@sourceware.org> (raw) https://gcc.gnu.org/g:51d702f3baf73aa4016b9798045d13318074ca1e commit r14-3277-g51d702f3baf73aa4016b9798045d13318074ca1e Author: Jonathan Wakely <jwakely@redhat.com> Date: Wed Aug 16 21:29:46 2023 +0100 libstdc++: Disable PCH for tests that rely on include order These tests expect to be able to #undef a feature test macro and then include <version> to get it redefined. But if <version> has already been included by the <bits/stdc++.h> PCH then including it again does nothing and the macro remains undefined. libstdc++-v3/ChangeLog: * testsuite/24_iterators/move_iterator/p2520r0.cc: Add no_pch. * testsuite/std/format/functions/format.cc: Likewise. * testsuite/std/format/functions/format_c++23.cc: Likewise. Diff: --- libstdc++-v3/testsuite/24_iterators/move_iterator/p2520r0.cc | 1 + libstdc++-v3/testsuite/std/format/functions/format.cc | 1 + libstdc++-v3/testsuite/std/format/functions/format_c++23.cc | 1 + 3 files changed, 3 insertions(+) diff --git a/libstdc++-v3/testsuite/24_iterators/move_iterator/p2520r0.cc b/libstdc++-v3/testsuite/24_iterators/move_iterator/p2520r0.cc index 883d6cc09e00..e36ac574a8ec 100644 --- a/libstdc++-v3/testsuite/24_iterators/move_iterator/p2520r0.cc +++ b/libstdc++-v3/testsuite/24_iterators/move_iterator/p2520r0.cc @@ -1,5 +1,6 @@ // { dg-options "-std=gnu++20" } // { dg-do compile { target c++20 } } +// { dg-add-options no_pch } // Verify P2520R0 changes to move_iterator's iterator_concept, which we treat // as a DR against C++20. diff --git a/libstdc++-v3/testsuite/std/format/functions/format.cc b/libstdc++-v3/testsuite/std/format/functions/format.cc index a8d5b652a5eb..4db5202815d6 100644 --- a/libstdc++-v3/testsuite/std/format/functions/format.cc +++ b/libstdc++-v3/testsuite/std/format/functions/format.cc @@ -1,5 +1,6 @@ // { dg-options "-std=gnu++20" } // { dg-do run { target c++20 } } +// { dg-add-options no_pch } #include <format> diff --git a/libstdc++-v3/testsuite/std/format/functions/format_c++23.cc b/libstdc++-v3/testsuite/std/format/functions/format_c++23.cc index f20c46cd7e38..3caa70fcdf2d 100644 --- a/libstdc++-v3/testsuite/std/format/functions/format_c++23.cc +++ b/libstdc++-v3/testsuite/std/format/functions/format_c++23.cc @@ -1,4 +1,5 @@ // { dg-do run { target c++23 } } +// { dg-add-options no_pch } // This test does not have -std=gnu++20 in dg-options so that format.cc // can be tested for e.g. -std=c++26 #include "format.cc"
reply other threads:[~2023-08-17 7:45 UTC|newest] Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230817074510.16F7E385558A@sourceware.org \ --to=redi@gcc.gnu.org \ --cc=gcc-cvs@gcc.gnu.org \ --cc=libstdc++-cvs@gcc.gnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).