From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2181) id B7C173882041; Fri, 18 Aug 2023 22:49:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B7C173882041 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1692398995; bh=1w0TKGofupN6KdAzJiyus55klAnU8pX6Y2DMj+S2f/A=; h=From:To:Subject:Date:From; b=hST86AKwc9QMZ+9DhyX/jUYM4sForXxbEt2RDbv6gKRbY16RFWwUKJ+FoBBe0YYed g7LlxxQdycOixymXD9nsxJhJbcorjwXEXb7soTDKEQg4kHeULEytN/pFhdedJ3m3+F zkws2o1MsDyRzo7nfdKjSpDQor5Icp3Gg8qdVrS8= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jonathan Wakely To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r14-3329] libstdc++: Revert pre-C++23 support for 16-bit float types [PR111060] X-Act-Checkin: gcc X-Git-Author: Jonathan Wakely X-Git-Refname: refs/heads/master X-Git-Oldrev: 6785917c9103e18bba0d718ac3b65a386d9a14f7 X-Git-Newrev: 27d0cfcb2b33de07351d9cb26f62d04d7416716c Message-Id: <20230818224955.B7C173882041@sourceware.org> Date: Fri, 18 Aug 2023 22:49:55 +0000 (GMT) List-Id: https://gcc.gnu.org/g:27d0cfcb2b33de07351d9cb26f62d04d7416716c commit r14-3329-g27d0cfcb2b33de07351d9cb26f62d04d7416716c Author: Jonathan Wakely Date: Fri Aug 18 13:10:15 2023 +0100 libstdc++: Revert pre-C++23 support for 16-bit float types [PR111060] In r14-3304-g1a566fddea212a and r14-3305-g6cf214b4fc97f5 I tried to enable std::format for 16-bit float types before C++23. This causes errors for targets where the types are defined but can't actually be used, e.g. i686 without sse2. Make the std::numeric_limits and std::formatter specializations for _Float16 and __bfloat16_t depend on the __STDCPP_FLOAT16_T__ and __STDCPP_BFLOAT16_T__ macros again, so they're only defined for C++23 when the type is fully supported. This is OK because the main point of my earlier commits was to add better support for _Float32 and _Float64. It seems fine for the new 16-bit types to only be supported for C++23, as they were never present before GCC 13 anyway. libstdc++-v3/ChangeLog: PR target/111060 * include/std/format (formatter): Only define specializations for 16-bit floating-point types for C++23. * include/std/limits (numeric_limits): Likewise. Diff: --- libstdc++-v3/include/std/format | 4 ++-- libstdc++-v3/include/std/limits | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/libstdc++-v3/include/std/format b/libstdc++-v3/include/std/format index 648f847ad969..f3d9ae152f90 100644 --- a/libstdc++-v3/include/std/format +++ b/libstdc++-v3/include/std/format @@ -2083,7 +2083,7 @@ namespace __format }; #endif -#if defined(__FLT16_DIG__) +#ifdef __STDCPP_FLOAT16_T__ // Reuse __formatter_fp::format for _Float16. template<__format::__char _CharT> struct formatter<_Float16, _CharT> @@ -2171,7 +2171,7 @@ namespace __format }; #endif -#if defined(__BFLT16_DIG__) +#ifdef __STDCPP_BFLOAT16_T__ // Reuse __formatter_fp::format for bfloat16_t. template<__format::__char _CharT> struct formatter<__gnu_cxx::__bfloat16_t, _CharT> diff --git a/libstdc++-v3/include/std/limits b/libstdc++-v3/include/std/limits index 7a59e7520ebc..ec0b7a1ca7bf 100644 --- a/libstdc++-v3/include/std/limits +++ b/libstdc++-v3/include/std/limits @@ -1982,7 +1982,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION = round_to_nearest; \ }; \ -#ifdef __FLT16_DIG__ +#ifdef __STDCPP_FLOAT16_T__ __glibcxx_float_n(16) #endif #ifdef __FLT32_DIG__ @@ -2002,7 +2002,7 @@ __glibcxx_float_n(128) # undef __max_digits10 #endif -#ifdef __BFLT16_DIG__ +#ifdef __STDCPP_BFLOAT16_T__ __extension__ template<> struct numeric_limits<__gnu_cxx::__bfloat16_t> @@ -2079,7 +2079,7 @@ __glibcxx_float_n(128) static _GLIBCXX_USE_CONSTEXPR float_round_style round_style = round_to_nearest; }; -#endif +#endif // __STDCPP_BFLOAT16_T__ #if defined(_GLIBCXX_USE_FLOAT128) // We either need Q literal suffixes, or IEEE double.