From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2181) id EFA5E385C40F; Wed, 15 Nov 2023 11:33:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EFA5E385C40F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1700047981; bh=1QdDAfT4kzNrHEt/w8Oc1Ou4/sxiOldiylXxu/nSVOE=; h=From:To:Subject:Date:From; b=WLUcK7UE1opV7Re71HbfSM0u6oZSnKAFbEpOPBm2ds+VIfn+tf0r0xV+6BuvMxUen rGU3AgwFh0Ehr00NWB9WQrLYygOslW+E4zmHQ7I3GfQOiTcV+YfaQT7PxkTm8Tv2Fm wgnNJv2eACQHD0huhgaxyaJ93IjUGaKAbQsGCzFQ= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jonathan Wakely To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r13-8072] libstdc++: Fix std::deque::operator[] Xmethod [PR112491] X-Act-Checkin: gcc X-Git-Author: Jonathan Wakely X-Git-Refname: refs/heads/releases/gcc-13 X-Git-Oldrev: b51b9e0861548e4b7a77f1d2cfcecb26440a0859 X-Git-Newrev: 5d6f62c9b2377b9b4c5b8c2eb1a6bcf00ba8ab2c Message-Id: <20231115113301.EFA5E385C40F@sourceware.org> Date: Wed, 15 Nov 2023 11:33:01 +0000 (GMT) List-Id: https://gcc.gnu.org/g:5d6f62c9b2377b9b4c5b8c2eb1a6bcf00ba8ab2c commit r13-8072-g5d6f62c9b2377b9b4c5b8c2eb1a6bcf00ba8ab2c Author: Jonathan Wakely Date: Tue Nov 14 15:08:13 2023 +0000 libstdc++: Fix std::deque::operator[] Xmethod [PR112491] The Xmethod for std::deque::operator[] has the same bug that I recently fixed for the std::deque::size() Xmethod. The first node might have unused capacity at the start, which needs to be accounted for when indexing into the deque. libstdc++-v3/ChangeLog: PR libstdc++/112491 * python/libstdcxx/v6/xmethods.py (DequeWorkerBase.index): Correctly handle unused capacity at the start of the first node. * testsuite/libstdc++-xmethods/deque.cc: Check index operator when elements have been removed from the front. (cherry picked from commit 452476db0c705caeac8712d560fc16ced0ca5226) Diff: --- libstdc++-v3/python/libstdcxx/v6/xmethods.py | 12 ++++++++---- libstdc++-v3/testsuite/libstdc++-xmethods/deque.cc | 6 +++++- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/libstdc++-v3/python/libstdcxx/v6/xmethods.py b/libstdc++-v3/python/libstdcxx/v6/xmethods.py index dcef285180a..f29bc2d40fb 100644 --- a/libstdc++-v3/python/libstdcxx/v6/xmethods.py +++ b/libstdc++-v3/python/libstdcxx/v6/xmethods.py @@ -195,7 +195,7 @@ class DequeWorkerBase(gdb.xmethod.XMethodWorker): def size(self, obj): start = obj['_M_impl']['_M_start'] finish = obj['_M_impl']['_M_finish'] - if not start['_M_node']: + if start['_M_cur'] == finish['_M_cur']: return 0 return (self._bufsize * (finish['_M_node'] - start['_M_node'] - 1) @@ -203,9 +203,13 @@ class DequeWorkerBase(gdb.xmethod.XMethodWorker): + (start['_M_last'] - start['_M_cur'])) def index(self, obj, idx): - first_node = obj['_M_impl']['_M_start']['_M_node'] - index_node = first_node + int(idx) // self._bufsize - return index_node[0][idx % self._bufsize] + start = obj['_M_impl']['_M_start'] + first_node_size = start['_M_last'] - start['_M_cur'] + if idx < first_node_size: + return start['_M_cur'][idx] + idx = idx - first_node_size + index_node = start['_M_node'][1 + int(idx) // self._bufsize] + return index_node[idx % self._bufsize] class DequeEmptyWorker(DequeWorkerBase): diff --git a/libstdc++-v3/testsuite/libstdc++-xmethods/deque.cc b/libstdc++-v3/testsuite/libstdc++-xmethods/deque.cc index e4077c14ff5..6058d23c87a 100644 --- a/libstdc++-v3/testsuite/libstdc++-xmethods/deque.cc +++ b/libstdc++-v3/testsuite/libstdc++-xmethods/deque.cc @@ -69,20 +69,24 @@ main () // PR libstdc++/112491 std::deque q5; - q5.push_front(0); + q5.push_front(5); // { dg-final { note-test q5.size() 1 } } +// { dg-final { note-test q5\[0\] 5 } } std::deque q6 = q1; q6.pop_front(); // { dg-final { note-test {q6.size() == (q1_size-1)} true } } +// { dg-final { note-test q6\[1\] 102 } } std::deque q7 = q2; q7.pop_front(); q7.pop_front(); // { dg-final { note-test {q7.size() == (q2_size-2)} true } } +// { dg-final { note-test q7\[1\] 203 } } std::deque q8 = q3; q8.pop_front(); q8.pop_front(); q8.pop_front(); // { dg-final { note-test {q8.size() == (q3_size-3)} true } } +// { dg-final { note-test q8\[1\] 304 } } std::deque q9 = q8; q9.clear(); // { dg-final { note-test q9.size() 0 } }