From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1888) id BE3083858D38; Wed, 3 Jan 2024 16:00:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BE3083858D38 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1704297656; bh=wHRJPy8l5zUJw3uIR9FSwPmegyCBuETBYzOC0kVc+qs=; h=From:To:Subject:Date:From; b=MuyN1p3XOilNPaH7NZ7aq2P8JC0mzOe3ug4qBFKD2c8nI06kWgt+Q5AtUJ02ftF9w iXoMIpE3PTz6SFoJ5iYDrGu3tKloILrmytdZP6Gg6kFKpAMejoMr8KpCXx4EoqBc5z yNKFseRM+Nov4EzsqwMZL/9bDDa2yJAmqYmy558c= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Patrick Palka To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r12-10079] libstdc++: testsuite: Reduce max_size_type.cc exec time [PR113175] X-Act-Checkin: gcc X-Git-Author: Patrick Palka X-Git-Refname: refs/heads/releases/gcc-12 X-Git-Oldrev: 4ff9494434f46aa748b94ff2b3d54b30d214664f X-Git-Newrev: 1fb2b5c9a7fb212a5936cc702e49175ef988e5ad Message-Id: <20240103160056.BE3083858D38@sourceware.org> Date: Wed, 3 Jan 2024 16:00:56 +0000 (GMT) List-Id: https://gcc.gnu.org/g:1fb2b5c9a7fb212a5936cc702e49175ef988e5ad commit r12-10079-g1fb2b5c9a7fb212a5936cc702e49175ef988e5ad Author: Patrick Palka Date: Tue Jan 2 21:31:20 2024 -0500 libstdc++: testsuite: Reduce max_size_type.cc exec time [PR113175] The adjustment to max_size_type.cc in r14-205-g83470a5cd4c3d2 inadvertently increased the execution time of this test by over 5x due to making the two main loops actually run in the signed_p case instead of being dead code. To compensate, this patch cuts the relevant loops' range [-1000,1000] by 10x as proposed in the PR. This shouldn't significantly weaken the test since the same important edge cases are still checked in the smaller range and/or elsewhere. On my machine this reduces the test's execution time by roughly 10x (and 1.6x relative to before r14-205). PR testsuite/113175 libstdc++-v3/ChangeLog: * testsuite/std/ranges/iota/max_size_type.cc (test02): Reduce 'limit' to 100 from 1000 and adjust 'log2_limit' accordingly. (test03): Likewise. (cherry picked from commit a138b99646a5551c53b860648521adb5bfe8c2fa) Diff: --- libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc b/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc index 5fc798cc60d..5c41b5629b0 100644 --- a/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc +++ b/libstdc++-v3/testsuite/std/ranges/iota/max_size_type.cc @@ -200,8 +200,8 @@ test02() using max_type = std::conditional_t; using shorten_type = std::conditional_t; const int hw_type_bit_size = sizeof(hw_type) * __CHAR_BIT__; - const int limit = 1000; - const int log2_limit = 10; + const unsigned limit = 100; + const int log2_limit = 7; static_assert((1 << log2_limit) >= limit); const int min = (signed_p ? -limit : 0); const int max = limit; @@ -258,8 +258,8 @@ test03() using max_type = std::conditional_t; using base_type = std::conditional_t; constexpr int hw_type_bit_size = sizeof(hw_type) * __CHAR_BIT__; - constexpr int limit = 1000; - constexpr int log2_limit = 10; + constexpr unsigned limit = 100; + constexpr int log2_limit = 7; static_assert((1 << log2_limit) >= limit); const int min = (signed_p ? -limit : 0); const int max = limit;