From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1734) id 9D9BC3858C2A; Sat, 20 Jan 2024 20:42:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9D9BC3858C2A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1705783362; bh=Vtuo88Cv9GCprzQBHKWPNF48jc/c6oPcErUyPmsr59M=; h=From:To:Subject:Date:From; b=E3UE99lORrwBlzwBFAS4iwHpIMooxsB8IS009GekDaZWqjb8OwvzJaS2fSbVmC6nJ FUNw5J0ZSexfJO7CCBs5LOw1ES91lmDutS0AEWdwxqgvqhdweQ//5f2aXiXObCDiA9 TYj1MpveLmRzfkrewR2uiY3t2aF/enZXl0bKyHMs= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Marek Polacek To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r14-8307] libstdc++: suppress -Wdangling-reference with operator| [PR111410] X-Act-Checkin: gcc X-Git-Author: Marek Polacek X-Git-Refname: refs/heads/trunk X-Git-Oldrev: 17473a93cff5340acfc293299a2f9a5857a50909 X-Git-Newrev: 7db802d972e622242d015ecd5a8cecf63e69a45a Message-Id: <20240120204242.9D9BC3858C2A@sourceware.org> Date: Sat, 20 Jan 2024 20:42:42 +0000 (GMT) List-Id: https://gcc.gnu.org/g:7db802d972e622242d015ecd5a8cecf63e69a45a commit r14-8307-g7db802d972e622242d015ecd5a8cecf63e69a45a Author: Marek Polacek Date: Fri Jan 19 15:27:51 2024 -0500 libstdc++: suppress -Wdangling-reference with operator| [PR111410] It seems to me that we should exclude std::ranges::views::__adaptor::operator| from the -Wdangling-reference warning. It's commonly used when handling ranges. PR c++/111410 libstdc++-v3/ChangeLog: * include/std/ranges: Add #pragma to disable -Wdangling-reference with std::ranges::views::__adaptor::operator|. gcc/testsuite/ChangeLog: * g++.dg/warn/Wdangling-reference17.C: New test. Diff: --- gcc/testsuite/g++.dg/warn/Wdangling-reference17.C | 15 +++++++++++++++ libstdc++-v3/include/std/ranges | 3 +++ 2 files changed, 18 insertions(+) diff --git a/gcc/testsuite/g++.dg/warn/Wdangling-reference17.C b/gcc/testsuite/g++.dg/warn/Wdangling-reference17.C new file mode 100644 index 00000000000..223698422c2 --- /dev/null +++ b/gcc/testsuite/g++.dg/warn/Wdangling-reference17.C @@ -0,0 +1,15 @@ +// PR c++/111410 +// { dg-do compile { target c++20 } } +// { dg-options "-Wdangling-reference" } + +#include +#include + +int main() +{ + std::vector v{1, 2, 3, 4, 5}; + for (auto i : std::span{v} | std::views::take(1)) + { + (void) i; + } +} diff --git a/libstdc++-v3/include/std/ranges b/libstdc++-v3/include/std/ranges index 7ef835f486a..f2413badd9c 100644 --- a/libstdc++-v3/include/std/ranges +++ b/libstdc++-v3/include/std/ranges @@ -942,6 +942,8 @@ namespace views::__adaptor concept __is_range_adaptor_closure = requires (_Tp __t) { __adaptor::__is_range_adaptor_closure_fn(__t, __t); }; +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wdangling-reference" // range | adaptor is equivalent to adaptor(range). template requires __is_range_adaptor_closure<_Self> @@ -961,6 +963,7 @@ namespace views::__adaptor return _Pipe, decay_t<_Rhs>>{std::forward<_Lhs>(__lhs), std::forward<_Rhs>(__rhs)}; } +#pragma GCC diagnostic pop // The base class of every range adaptor non-closure. //