public inbox for libstdc++-cvs@sourceware.org
help / color / mirror / Atom feed
From: Jonathan Yong <jyong@gcc.gnu.org>
To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org
Subject: [gcc r14-8818] libstdc++: /dev/null is not accessible on Windows
Date: Tue,  6 Feb 2024 08:23:58 +0000 (GMT)	[thread overview]
Message-ID: <20240206082359.28C403858D33@sourceware.org> (raw)

https://gcc.gnu.org/g:1e4664b97daf85d3134baa47a5af3db23658df34

commit r14-8818-g1e4664b97daf85d3134baa47a5af3db23658df34
Author: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>
Date:   Mon Feb 5 20:06:03 2024 +0100

    libstdc++: /dev/null is not accessible on Windows
    
    When running the DejaGNU testsuite on a toolchain built for native
    Windows, the path /dev/null can't be used to open a stream to void.
    On native Windows, the resource is instead named "nul".
    
    In 17_intro/tag_type_explicit_ctor.cc, the following statement would
    fail to match when the DejaGNU testsuite is running in cygwin with a
    native toolchain.
    // dg-error 53 "explicit" "" { target hosted }
    
    The "target hosted"-check is using cpp to verify if _GLIBCXX_HOSTED is
    defined and discards the output by simply redirecting it to /dev/null.
    In v3_target_compile, it's overridden to "nul" for MinGW targets, but
    the same rule applies when host is cygwin, so replace the condition
    with a check for Windows.
    
    The error in the log would look like this for the "target hosted" check:
    cc1plus.exe: fatal error: opening output file /dev/null: No such file or directory
    
    The tag_type_explicit_ctor.cc test fails with this on Windows:
    .../tag_type_explicit_ctor.cc:53: error: converting to 'std::defer_lock_t' from initializer list would use explicit constructor 'constexpr std::defer_lock_t::defer_lock_t()'
    .../tag_type_explicit_ctor.cc:54: error: converting to 'std::try_to_lock_t' from initializer list would use explicit constructor 'constexpr std::try_to_lock_t::try_to_lock_t()'
    .../tag_type_explicit_ctor.cc:55: error: converting to 'std::try_to_lock_t' from initializer list would use explicit constructor 'constexpr std::try_to_lock_t::try_to_lock_t()'
    .../tag_type_explicit_ctor.cc:67: error: converting to 'std::defer_lock_t' from initializer list would use explicit constructor 'constexpr std::defer_lock_t::defer_lock_t()'
    .../tag_type_explicit_ctor.cc:68: error: converting to 'std::try_to_lock_t' from initializer list would use explicit constructor 'constexpr std::try_to_lock_t::try_to_lock_t()'
    .../tag_type_explicit_ctor.cc:69: error: converting to 'std::adopt_lock_t' from initializer list would use explicit constructor 'constexpr std::adopt_lock_t::adopt_lock_t()'
    
    Patch has been verified on Windows and Linux.
    
    libstdc++-v3:
    
            * testsuite/lib/libstdc++.exp: Use "nul" for Windows, "/dev/null"
            for other environments.
    
    Signed-off-by: Torbjörn SVENSSON <torbjorn.svensson@foss.st.com>

Diff:
---
 libstdc++-v3/testsuite/lib/libstdc++.exp | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/libstdc++-v3/testsuite/lib/libstdc++.exp b/libstdc++-v3/testsuite/lib/libstdc++.exp
index 24d1b43f11be..58804ecab267 100644
--- a/libstdc++-v3/testsuite/lib/libstdc++.exp
+++ b/libstdc++-v3/testsuite/lib/libstdc++.exp
@@ -615,11 +615,14 @@ proc v3_target_compile { source dest type options } {
 	}
     }
 
-    # Small adjustment for MinGW hosts.
-    if { $dest == "/dev/null" && [ishost "*-*-mingw*"] } {
+    # Small adjustment for Windows hosts.
+    if { $dest == "/dev/null"
+	  && [info exists ::env(OS)] && [string match "Windows*" $::env(OS)] } {
 	if { $type == "executable" } {
 	    set dest "x.exe"
 	} else {
+	    # Windows uses special file named "nul" as a substitute for
+	    # /dev/null
 	    set dest "nul"
 	}
     }

                 reply	other threads:[~2024-02-06  8:23 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240206082359.28C403858D33@sourceware.org \
    --to=jyong@gcc.gnu.org \
    --cc=gcc-cvs@gcc.gnu.org \
    --cc=libstdc++-cvs@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).