From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2181) id E13253858C78; Mon, 18 Mar 2024 11:22:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E13253858C78 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1710760972; bh=klP6mAxXB/DYSSpPf8TmLKOMfQC4I6zOam60u+5h6u4=; h=From:To:Subject:Date:From; b=IkZb/851uGTuweZF8E93nCw5WSJJ9HBdZZaB+riPVe6e9IvtuGcMqP1eY85WHqLiy NigaEoGJHtKbT+8pJ3FgULy6Bi44L7plJxzOITfMF2J4nYyzOKMbJHWgBFlC7ZASgD 6PKzD/oJM6U78uomzhQgTYl8SLVZgQK/6senppdw= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jonathan Wakely To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r13-8463] libstdc++: Move test error_category to global scope X-Act-Checkin: gcc X-Git-Author: Jonathan Wakely X-Git-Refname: refs/heads/releases/gcc-13 X-Git-Oldrev: d9d51e0552693bf1bcf6f23d53d058d60d72416e X-Git-Newrev: e4ac0519ec85fd422ee2987cc8308dced96c68be Message-Id: <20240318112252.E13253858C78@sourceware.org> Date: Mon, 18 Mar 2024 11:22:52 +0000 (GMT) List-Id: https://gcc.gnu.org/g:e4ac0519ec85fd422ee2987cc8308dced96c68be commit r13-8463-ge4ac0519ec85fd422ee2987cc8308dced96c68be Author: Jonathan Wakely Date: Wed Mar 13 10:02:12 2024 +0000 libstdc++: Move test error_category to global scope A recent GDB change causes this test to fail due to missing RTTI for the custom_cast type. This is presumably because the custom_cat type was defined as a local class, so has no linkage. Moving it to local scope seems to fix the test regressions, and probably makes the test more realistic as a local class with no linkage isn't practical to use as an error category that almost certainly needs to be referred to in other scopes. libstdc++-v3/ChangeLog: * testsuite/libstdc++-prettyprinters/cxx11.cc: Move custom_cat to namespace scope. (cherry picked from commit a8c7c3a40953e34f57278d224a07dc3698c64a84) Diff: --- libstdc++-v3/testsuite/libstdc++-prettyprinters/cxx11.cc | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libstdc++-v3/testsuite/libstdc++-prettyprinters/cxx11.cc b/libstdc++-v3/testsuite/libstdc++-prettyprinters/cxx11.cc index 0f1736a1550..973fa936d9e 100644 --- a/libstdc++-v3/testsuite/libstdc++-prettyprinters/cxx11.cc +++ b/libstdc++-v3/testsuite/libstdc++-prettyprinters/cxx11.cc @@ -63,6 +63,11 @@ struct datum std::unique_ptr global; +struct custom_cat : std::error_category { + const char* name() const noexcept { return "miaow"; } + std::string message(int) const { return ""; } +}; + int main() { @@ -179,10 +184,7 @@ main() std::error_condition ecinval = std::make_error_condition(std::errc::invalid_argument); // { dg-final { note-test ecinval {std::error_condition = {"generic": EINVAL}} } } - struct custom_cat : std::error_category { - const char* name() const noexcept { return "miaow"; } - std::string message(int) const { return ""; } - } cat; + custom_cat cat; std::error_code emiaow(42, cat); // { dg-final { note-test emiaow {std::error_code = {custom_cat: 42}} } } std::error_condition ecmiaow(42, cat);