From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2181) id 16B94385840A; Mon, 18 Mar 2024 14:05:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 16B94385840A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1710770706; bh=g6X7VvJ4U/QUdJny1iMvwa0poaVjdyzHhtxwBFu6XRs=; h=From:To:Subject:Date:From; b=bLdiojrP3GO5RxLnlGaXdsq8sTEQscfOdlxQHK/9jNFsX9XngIpaFhTGc7zior4DN X6xYRbuq0OceuPHCAzm6YBjvxSgDo2JWhjSamwx9TDurZ0FFjF2O2arzizwvnF9t7D IATGnEqM5Fa5ve9n88iTUjX2DaCt7SGM1DKP4FUE= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Jonathan Wakely To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r12-10241] libstdc++: Fix PSTL test that fails in C++20 X-Act-Checkin: gcc X-Git-Author: Jonathan Wakely X-Git-Refname: refs/heads/releases/gcc-12 X-Git-Oldrev: 1bb2bfb5d984456f59b42228f06d4ad4976358e7 X-Git-Newrev: ceb82ba594a6c24f33351eda0ae3fbb6fd6d841a Message-Id: <20240318140506.16B94385840A@sourceware.org> Date: Mon, 18 Mar 2024 14:05:06 +0000 (GMT) List-Id: https://gcc.gnu.org/g:ceb82ba594a6c24f33351eda0ae3fbb6fd6d841a commit r12-10241-gceb82ba594a6c24f33351eda0ae3fbb6fd6d841a Author: Jonathan Wakely Date: Thu Jun 1 16:49:53 2023 +0100 libstdc++: Fix PSTL test that fails in C++20 This test fails in C++20 and later due to a warning: warning: C++20 says that these are ambiguous, even though the second is reversed: note: candidate 1: 'bool MyClass::operator==(const MyClass&)' note: candidate 2: 'bool MyClass::operator==(const MyClass&)' (reversed) note: try making the operator a 'const' member function FAIL: 26_numerics/pstl/numeric_ops/transform_reduce.cc (test for excess errors) libstdc++-v3/ChangeLog: * testsuite/26_numerics/pstl/numeric_ops/transform_reduce.cc: Add const to equality operator. (cherry picked from commit f8403c43045cd56b5f775e1cf12a3f22feca4b58) Diff: --- libstdc++-v3/testsuite/26_numerics/pstl/numeric_ops/transform_reduce.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libstdc++-v3/testsuite/26_numerics/pstl/numeric_ops/transform_reduce.cc b/libstdc++-v3/testsuite/26_numerics/pstl/numeric_ops/transform_reduce.cc index ec020b42bbb..bec1c141278 100644 --- a/libstdc++-v3/testsuite/26_numerics/pstl/numeric_ops/transform_reduce.cc +++ b/libstdc++-v3/testsuite/26_numerics/pstl/numeric_ops/transform_reduce.cc @@ -68,7 +68,7 @@ class MyClass } friend MyClass operator*(const MyClass& x, const MyClass& y) { return MyClass(x.my_field * y.my_field); } bool - operator==(const MyClass& in) + operator==(const MyClass& in) const { return my_field == in.my_field; }