From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1720) id 22807385842A; Mon, 18 Mar 2024 21:32:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 22807385842A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1710797546; bh=/nSvfUbuvj1NPe3iNKyX70XSIy7NbzWlhqA/GAB0o+0=; h=From:To:Subject:Date:From; b=PS/RTDF0cPBdZDiN6w0rMzLqTYzRV9rLb7E3IVxp2XxdPgsqhEsYPv7sgfVUXPPrP BfDJtke8Evt/IyI3PsxdQ9t5LnmBIZjJUKhsXh9yXv/I+OZqALGFr796TZvF1tAgkq PSJ6FKAvBmMPHt3tWOjW4SSJhEIfwokEVvSIBUpA= MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" From: Francois Dumont To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r14-9524] libstdc++: Fix _Safe_local_iterator<>::_M_valid_range X-Act-Checkin: gcc X-Git-Author: =?utf-8?q?Fran=C3=A7ois_Dumont?= X-Git-Refname: refs/heads/master X-Git-Oldrev: b96c5436880d7926299314a33c953171082ab59e X-Git-Newrev: 5f6e0853c30fec72d977afaa6f7a5633a8d910be Message-Id: <20240318213226.22807385842A@sourceware.org> Date: Mon, 18 Mar 2024 21:32:26 +0000 (GMT) List-Id: https://gcc.gnu.org/g:5f6e0853c30fec72d977afaa6f7a5633a8d910be commit r14-9524-g5f6e0853c30fec72d977afaa6f7a5633a8d910be Author: François Dumont Date: Sun Mar 17 17:30:58 2024 +0100 libstdc++: Fix _Safe_local_iterator<>::_M_valid_range Unordered container local_iterator range shall not contain any singular iterator unless both iterators are both value-initialized. libstdc++-v3/ChangeLog: * include/debug/safe_local_iterator.tcc (_Safe_local_iterator::_M_valid_range): Add _M_value_initialized and _M_singular checks. * testsuite/23_containers/unordered_set/debug/114316.cc: New test case. Diff: --- libstdc++-v3/include/debug/safe_local_iterator.tcc | 8 ++++++- .../23_containers/unordered_set/debug/114316.cc | 28 ++++++++++++++++++++++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/libstdc++-v3/include/debug/safe_local_iterator.tcc b/libstdc++-v3/include/debug/safe_local_iterator.tcc index 90e60e37c32..6d546ec040c 100644 --- a/libstdc++-v3/include/debug/safe_local_iterator.tcc +++ b/libstdc++-v3/include/debug/safe_local_iterator.tcc @@ -78,7 +78,13 @@ namespace __gnu_debug _M_valid_range(const _Safe_local_iterator& __rhs, std::pair& __dist) const { - if (!_M_can_compare(__rhs)) + if (_M_value_initialized() && __rhs._M_value_initialized()) + { + __dist = { 0, __dp_exact }; + return true; + } + + if (_M_singular() || __rhs._M_singular() || !_M_can_compare(__rhs)) return false; if (bucket() != __rhs.bucket()) diff --git a/libstdc++-v3/testsuite/23_containers/unordered_set/debug/114316.cc b/libstdc++-v3/testsuite/23_containers/unordered_set/debug/114316.cc new file mode 100644 index 00000000000..41b649a9cbd --- /dev/null +++ b/libstdc++-v3/testsuite/23_containers/unordered_set/debug/114316.cc @@ -0,0 +1,28 @@ +// { dg-do run { target c++11 } } +// { dg-require-debug-mode "" } + +// PR libstdc++/114316 + +#include +#include + +#include + +void test01() +{ + std::unordered_set::iterator it{}; + VERIFY( std::find(it, it, 0) == it ); +} + +void test02() +{ + std::unordered_set::local_iterator it{}; + VERIFY( std::find(it, it, 0) == it ); +} + +int main() +{ + test01(); + test02(); + return 0; +}