From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1720) id 4B7A83858CD1; Mon, 18 Mar 2024 21:32:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4B7A83858CD1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1710797551; bh=caRGTCiH5pgBaKWSjmW19mLYI6vNWRaVaJQvcNgblzg=; h=From:To:Subject:Date:From; b=TXLlyR7MDpi0cUDcO6AJgp2XCFj+dAkssbpY+PYmz7gIEaA9X8tavMr5C+G9qRvoN Ph7Z7BnIDYSg8QsW/+UUkt1Q/LmGPoBp/xKWTOww8LAx/y7M3s29ci3WP8Y/2+fznt wzwUf4PaNM9Of+L71UFSnZqfZbjzuZKTu+bMW8gw= MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" From: Francois Dumont To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r14-9525] libstdc++: Fix N3344 behavior on _Safe_iterator::_M_can_advance X-Act-Checkin: gcc X-Git-Author: =?utf-8?q?Fran=C3=A7ois_Dumont?= X-Git-Refname: refs/heads/master X-Git-Oldrev: 5f6e0853c30fec72d977afaa6f7a5633a8d910be X-Git-Newrev: dda96a9d942d73a587e174dd5efe061208a195af Message-Id: <20240318213231.4B7A83858CD1@sourceware.org> Date: Mon, 18 Mar 2024 21:32:31 +0000 (GMT) List-Id: https://gcc.gnu.org/g:dda96a9d942d73a587e174dd5efe061208a195af commit r14-9525-gdda96a9d942d73a587e174dd5efe061208a195af Author: François Dumont Date: Sun Mar 17 19:06:55 2024 +0100 libstdc++: Fix N3344 behavior on _Safe_iterator::_M_can_advance We shall be able to advance from a 0 offset a value-initialized iterator. libstdc++-v3/ChangeLog: * include/debug/safe_iterator.tcc (_Safe_iterator<>::_M_can_advance): Accept 0 offset advance on value-initialized iterator. * testsuite/23_containers/vector/debug/n3644.cc: New test case. Diff: --- libstdc++-v3/include/debug/safe_iterator.tcc | 3 +++ .../testsuite/23_containers/vector/debug/n3644.cc | 16 ++++++++++++++++ 2 files changed, 19 insertions(+) diff --git a/libstdc++-v3/include/debug/safe_iterator.tcc b/libstdc++-v3/include/debug/safe_iterator.tcc index 4b2baf2980e..deaa84d0a1f 100644 --- a/libstdc++-v3/include/debug/safe_iterator.tcc +++ b/libstdc++-v3/include/debug/safe_iterator.tcc @@ -86,6 +86,9 @@ namespace __gnu_debug _Safe_iterator<_Iterator, _Sequence, _Category>:: _M_can_advance(difference_type __n, bool __strict) const { + if (this->_M_value_initialized() && __n == 0) + return true; + if (this->_M_singular()) return false; diff --git a/libstdc++-v3/testsuite/23_containers/vector/debug/n3644.cc b/libstdc++-v3/testsuite/23_containers/vector/debug/n3644.cc new file mode 100644 index 00000000000..052c52f26b7 --- /dev/null +++ b/libstdc++-v3/testsuite/23_containers/vector/debug/n3644.cc @@ -0,0 +1,16 @@ +// { dg-do run { target c++11 } } +// { dg-require-debug-mode "" } + +#include +#include + +#include + +int main() +{ + std::vector::iterator it{}; + auto cpy = it; + std::advance(it, 0); + VERIFY( it == cpy ); + return 0; +}