From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1698) id DB44B38460B1; Wed, 3 Apr 2024 14:56:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DB44B38460B1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1712156207; bh=Qob3U8r0ebFyY99XMYli8NH1ryBAQ5QfoNhLp4x4+Yg=; h=From:To:Subject:Date:From; b=EKQsor2IFFwvyASb/GPGphkXxPZFe4tKdrBx7pOj9wr8g7tCDRSZnPnBj1QPK0/ga 598BG9wXNx2rkcwXkwBTmZeJD2GSXJegF7ddYdvpHJ8kM7Y10LrUVO1SZvp2xlvKuL hPRGeVjEqxHDAgv2W3XtyPRBC51ruc+9f1XkDd00= MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" From: Iain D Sandoe To: gcc-cvs@gcc.gnu.org, libstdc++-cvs@gcc.gnu.org Subject: [gcc r13-8575] libstdc++, Darwin: Do not use dev/null as the file for executables. X-Act-Checkin: gcc X-Git-Author: Iain Sandoe X-Git-Refname: refs/heads/releases/gcc-13 X-Git-Oldrev: baec3b8ea17b82d2e4895fda50d94f74cf63100c X-Git-Newrev: 6bcc8fd92c69a66d4a8531665225a75d81a9d146 Message-Id: <20240403145647.DB44B38460B1@sourceware.org> Date: Wed, 3 Apr 2024 14:56:47 +0000 (GMT) List-Id: https://gcc.gnu.org/g:6bcc8fd92c69a66d4a8531665225a75d81a9d146 commit r13-8575-g6bcc8fd92c69a66d4a8531665225a75d81a9d146 Author: Iain Sandoe Date: Tue Mar 19 10:40:50 2024 +0000 libstdc++, Darwin: Do not use dev/null as the file for executables. Darwin has a separate debug linker, which is invoked when the command line contains source files and debug is enabled. Using /dev/null as the executable name does not, therefore, work when debug is enabled, since the debug linker does not accept /dev/null as a valid executable name. The leads to incorrectly UNSUPPORTED testcases because of the unintended error result from the test compilation. The solution here is to use a temporary file that is deleted at the end of the test (which is the mechanism used elsewhere) libstdc++-v3/ChangeLog: * testsuite/lib/libstdc++.exp (v3_target_compile): Instead of /dev/null, use a temporary file for test executables on Darwin. Signed-off-by: Iain Sandoe (cherry picked from commit e47330d0742c985fd8d5fe7089aa381d34967d61) Diff: --- libstdc++-v3/testsuite/lib/libstdc++.exp | 20 +++++++++++++++++++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/libstdc++-v3/testsuite/lib/libstdc++.exp b/libstdc++-v3/testsuite/lib/libstdc++.exp index 6c57cfab725..d85ff7521c2 100644 --- a/libstdc++-v3/testsuite/lib/libstdc++.exp +++ b/libstdc++-v3/testsuite/lib/libstdc++.exp @@ -507,11 +507,15 @@ proc v3_target_compile { source dest type options } { } } + # For Windows and Darwin we might want to create a temporary file. + # Note that it needs deleting. + set file_to_delete "" # Small adjustment for Windows hosts. if { $dest == "/dev/null" && [info exists ::env(OS)] && [string match "Windows*" $::env(OS)] } { if { $type == "executable" } { set dest "x.exe" + set file_to_delete ${dest} } else { # Windows uses special file named "nul" as a substitute for # /dev/null @@ -519,11 +523,25 @@ proc v3_target_compile { source dest type options } { } } + # Using /dev/null as the executable name does not work on Darwin when + # debug is enabled, since the debug linker does not accept /dev/null as + # a valid executable name. + if { $dest == "/dev/null" && [istarget *-*-darwin*] + && $type == "executable" } { + set dest dev-null-[pid].exe + set file_to_delete ${dest} + } + lappend options "compiler=$cxx_final" lappend options "timeout=[timeout_value]" set comp_output [target_compile $source $dest $type $options] - + if { $type == "executable" && $file_to_delete != "" } { + file delete $file_to_delete + if { [istarget *-*-darwin*] && [file exists $file_to_delete.dSYM] } { + file delete -force $file_to_delete.dSYM + } + } return $comp_output }