From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by sourceware.org (Postfix) with ESMTPS id D17CA3858D20 for ; Wed, 20 Sep 2023 04:54:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D17CA3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-ed1-x535.google.com with SMTP id 4fb4d7f45d1cf-530fa34ab80so1071946a12.0 for ; Tue, 19 Sep 2023 21:54:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1695185687; x=1695790487; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ldfO2RqbyRm9eVslhyJzswVMoZefZmN9005xV7M51Vg=; b=OQEMAE62CPahA35TC9v6xBx2UVVglDYzCXcmn1GZJ5xtONXhrGZqs9klbrcCRhq/B6 N8WUSyXmGCDOPuOIHNcDDk5WmXbUTu7vB/3MxqDZqKTUHbmufREdX7DBuwQdAKLsG9w1 JIFKoMgpFmYpMDWxIR5zihV2AekNRgh/O/Fp9qQdVMM37cMFZbabTDlrkCIoovhVOFCr 4IA7XXKCmwVy0NRshs1y18Uca9J15DeWiiDgQsrliLmyRHsT2r876de9DF7Syzw/DGlK YEqAIbI2m/gIbUYcYGFX/WthIi6N3XiNnbv5oRq27cQoFXqps4iBYlPdcHRCVy2TxM8b qmUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695185687; x=1695790487; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ldfO2RqbyRm9eVslhyJzswVMoZefZmN9005xV7M51Vg=; b=ko03y4mdCzzuY7ORM9tpztSVNS74cSQG1c2RSF4Lg7CUGGK4Fbtxp+aCQaQYItypWY jK2hMFP+oF3dXeVSrflDGCJEo0cwcYAhcGv835c+jYAbLiAovwjb0fCxgKEK02kwbx+g 1gZg1C3dLMFaC82RE1HXMZOcdoKeZvLLd5CopqUn2AMKVJjzQ8TFuieBIqi13ppoabRv +pNIm7A55SY87PefWOfU1RSnnns0ZGCBp6igsMe6GF+fI4wcU9jLlzcaLPoZQIFS7RxQ +UasJ+vWhFVqkVSnltqQXoWG3Y2SNr/cK0ecgZss5gmR6QufTjTeKw5y9y6BLEGDUa0P 4mJQ== X-Gm-Message-State: AOJu0YwPASbacg8spxywYxzYR7VCQAi3LCC5kyOoIMSxYnR6cRzuWeUU REEZ5cRNyNdCUeIcRgMwKA7du0C4y9B/Dg== X-Google-Smtp-Source: AGHT+IFWzt+1v3pm1wsuhvsYcAZDScg5a8DLsM0fmxwiAbR8f4kbWhOddYpFmm5y0cfDayKonESgvw== X-Received: by 2002:a17:906:74db:b0:99c:5056:4e31 with SMTP id z27-20020a17090674db00b0099c50564e31mr2340734ejl.15.1695185687178; Tue, 19 Sep 2023 21:54:47 -0700 (PDT) Received: from [10.25.0.76] ([89.207.171.100]) by smtp.gmail.com with ESMTPSA id n25-20020a170906b31900b0099bcdfff7cbsm8840187ejz.160.2023.09.19.21.54.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 Sep 2023 21:54:46 -0700 (PDT) Message-ID: <04d3c568-1505-63c7-774e-362f93b65cf0@gmail.com> Date: Wed, 20 Sep 2023 06:54:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: std::experimental and versioned namespace Content-Language: en-US To: Jonathan Wakely Cc: libstdc++ References: <9e60d796-b675-1190-a795-349bd308933a@gmail.com> From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 19/09/2023 10:03, Jonathan Wakely wrote: > On Tue, 19 Sept 2023 at 06:10, François Dumont via Libstdc++ > wrote: >> I'm running 'make check-c++' in gnu-versioned_namespace mode and among >> all the failures are those: >> >> compiler exited with status 1 >> FAIL: g++.dg/contracts/contracts-access1.C (test for excess errors) >> Excess errors: >> contracts-access1.C:(.text._ZN4Base1bEv.pre[_ZN4Base1bEv]+0x64): >> undefined reference to >> `handle_contract_violation(std::experimental::contract_violation const&)' > The header uses the versioned namespace macros > for the contract_violation type: > > namespace std _GLIBCXX_VISIBILITY(default) > { > _GLIBCXX_BEGIN_NAMESPACE_VERSION > > namespace experimental > { > > But the compiler expects it to be in the std::experimental namespace. > >> I still need to find out what's going wrong but I also wonder if we need >> to use the versioned namespace for things in std::experimental namespace >> ? Those are already abi unstable, no ? > Yes, we can just remove the VERSION macros from the header. > And not from the whole std::experimental world then, surprising. Patch submitted.