From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 217AC3858C52; Mon, 30 Oct 2023 18:31:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 217AC3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 217AC3858C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698690702; cv=none; b=JbhMy5GDQMtvWz/CRsh9wLINX8L4AzfaTlvVy3xLKGVroIrZV3Cad91tRkDM4T9si2yq2l7gol6TLqMdYmPN8AhxqJUk9C+VbMnRKGcp+Bt/D4lm8oVLvhe7mGKqGaHYZY8uClQpOU2wAJ6WPwtmXVpO6Jy7qZp1nFEzcch4MTo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698690702; c=relaxed/simple; bh=2h58Lu/AZM9rgylMes68D0F3drDKWEefKT0sJKVfWxs=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=qrQ7g5GWO8M6D9N+1QoRvYpAn/UccHkOME3POQNYCFgbqLNLgJVE/irUgFHRfhNJYoHqaqTrGxLyAVksuPXjpQItM2s9Jl8TbVns0w7SfNHtXCJEhLlusdwrNohmruUxc/Di4M5Jpd9tt8foMdNQk1HsQH2vz74mG/ZYsFeevJU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-4083f613275so34971395e9.2; Mon, 30 Oct 2023 11:31:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698690699; x=1699295499; darn=gcc.gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/0SunqEf5M7kC4dK84173wdnXBS2Coy6I7RmbBJog6s=; b=No1LhmFyuN6oY9JPlFrohkPm2t0nhGtrn7b2z7npqvcNjd3DzmkbdKQBrCet0m+KmI VDiHb53uv0pKYxVS6GUOAhKp7LKYsjEuauSvOqOWpg2B2wIlFxznwxwos0a6RCmc/9BB ORtaKeCRZUS76d878JB1Pb5u1eTcbN9PlxS643ZT/MEdzxYDpRov+gTl3CUoCZvHcSMk nGQFyK0NOp+O+DphpBw50qucTLx1bRzFAXkqAGn/2LjXMVdDPgQyDFdV8bxmGon74qXb agf37q5xYyH2eIf2rpxFwXn/vTQEXJpvLJADtzRkT2KQI4hmtDsqXdiwF8F8C7HYm3t1 mVdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698690699; x=1699295499; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/0SunqEf5M7kC4dK84173wdnXBS2Coy6I7RmbBJog6s=; b=RezxRNTiuQZxk5lRhlnLZeoBpjZzRHxCqYlkQSPrhI2Zs2UV4ET4x7cSpcPwdjhrFo 04bTR5/52UKk89UhFOX5MONWzFYTfWqZR2BhiEuz9JpW/wvSsmov3Afib/QEbiqrPW28 wZ8hIvCzzO93VHJER5G1dSxmS13y6eCq0D8/bdWvVIZjkOqt8ujxtutEDuBcr0dR/dxf nv6kK+7OSoM937x1/Qj8itgqtAko0ntdjot6NFg+K49ymOfB2cTZGfYzk/gsgB1FOdTg fxWep+QoSVtajpKB+vrqLrIcnfDQEvZKKxf3uZLb8Cqs7Y8/QJCP/6uawhrX6wrHmLZV DoKA== X-Gm-Message-State: AOJu0Yx+7LONax1I7UHnC0Aum6gNy570JJAbP/TvOCaYKZfzl21h1D8G LUK8obnLNIhhpCnJa9aPc0RQicNyK/Q= X-Google-Smtp-Source: AGHT+IFN3g6+gE0s06ClwsB+m2lotDbr3DsGmQP4tiaWQNHCETXP9jxz44dvZzC+4HOQ9nsWBfM6kQ== X-Received: by 2002:a05:6000:bc4:b0:32d:aa11:221e with SMTP id dm4-20020a0560000bc400b0032daa11221emr8587614wrb.7.1698690699295; Mon, 30 Oct 2023 11:31:39 -0700 (PDT) Received: from [10.8.1.253] ([89.207.171.96]) by smtp.gmail.com with ESMTPSA id j15-20020adfb30f000000b0032d8eecf901sm8837748wrd.3.2023.10.30.11.31.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Oct 2023 11:31:38 -0700 (PDT) Message-ID: <06d14459-fd2a-48ec-9e8d-ba0a195fe83a@gmail.com> Date: Mon, 30 Oct 2023 19:31:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [committed][_GLIBCXX_INLINE_VERSION] Fix constract violation Content-Language: en-US To: Jonathan Wakely Cc: libstdc++ , gcc-patches References: From: =?UTF-8?Q?Fran=C3=A7ois_Dumont?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 30/10/2023 14:45, Jonathan Wakely wrote: > On Sun, 29 Oct 2023 at 21:11, François Dumont wrote: >> This fixes handle_contract_violation under versioned namespace mode. >> >> Tested under Linux x64 and confirmed to also fix Darwin build. >> >> libstdc++: [_GLIBCXX_INLINE_VERSION] Provide handle_contract_violation >> symbol >> >> libstdc++-v3/ChangeLog: >> >> * src/experimental/contract.cc >> [_GLIBCXX_INLINE_VERSION](handle_contract_violation): Provide >> symbol >> without version namespace decoration for gcc. >> +#if _GLIBCXX_INLINE_VERSION >> +// Provide symbol without version namespace decoration for gcc. > For the comment in the code, I think this would be better: > > // The compiler expects the contract_violation class to be in an unversioned > // namespace, so provide a forwarding function with the expected symbol name. Sure, I'll update it. > Do we want the forwarding function to be a weak symbol? The main > handler function is weak because we want users to be able to override > it with their own handler. But for this new forwarding function, they > can't even declare it (because it has a reserved name that doesn't > demangle to a valid type for the versioned namespace build). > Good point, I see no reason neither so I'll remove it.