From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 2DBDE3858C2F for ; Wed, 4 Oct 2023 15:54:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2DBDE3858C2F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696434889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GuIkXXj8UDeCyBimW7oMbX6BAnA+S06n4v+xucAxfYA=; b=ga4EaiW8/4S325ex+K3I2JD+REYHoGL2VYOa71mbrpLCVXd0GW531wu+MjaA0KdwztFCf7 FiPTe63GWVXYsnKrADRn+XqerHJ9ZY+SUxOXC/WHtqgViZZtGVXIU10MXqBnpm/vReFBvJ 9aXuDWdVz4plEDojCS0TTPJLsPhVSNk= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-207-w8fyKK4PONaG0IVZS01AXw-1; Wed, 04 Oct 2023 11:54:48 -0400 X-MC-Unique: w8fyKK4PONaG0IVZS01AXw-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-9adc78b386cso204371566b.0 for ; Wed, 04 Oct 2023 08:54:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696434887; x=1697039687; h=content-transfer-encoding:in-reply-to:from:cc:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=GuIkXXj8UDeCyBimW7oMbX6BAnA+S06n4v+xucAxfYA=; b=RF+TSTWzAqvo7xgRygV7W1ADShXCBDccnaBaI/t/+FwHj4N6+Co/Vvs9zIO9ndpyxe C+7Y5Ex1rqzWMncqLD+bCxwBiWUn4NzEUWmtH3PEbiCS2AIipNbPSmKFa6peFGFi+KbX dUtnDdbqUHLqUzo32kGuJ4/J9QA1NMs+x1tbMIvjh8PpqspEkyN/IY7oxgo5BaNy74HL CjvBVMRkoFqbkjInXSUCyVdouQ/PUMMg3hctYUtSuieDrPB1H3UVdX4aUx9bAFxJizab B79Fju1gX9+FR9P88N+Nmlw4VOFSS7froDK1omJuvM3uPOfanbiZ4LoCCe5VHAqTj8VX 6B9A== X-Gm-Message-State: AOJu0YwMGtv5vr2oFkZnme+ShZVYN+vVKWtiGs3PFt+LXz7IjNdnHv4O k0xNiibQN6wZT64F955hF37wseR31gsqem4s3whwvzrWFiI7LyMEDIFb/NFi1NP/icXxvOgJhl/ LW3tYCgPcgv63V30= X-Received: by 2002:a17:906:8452:b0:9b2:a7c9:fcfe with SMTP id e18-20020a170906845200b009b2a7c9fcfemr2088269ejy.36.1696434887359; Wed, 04 Oct 2023 08:54:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG1cS//T/QR2EPn3lp0MBoDcezA5O6L0a8SER+4k69fC6MW3KQSFT5ikvaP+r0v/HbZcvb/dw== X-Received: by 2002:a17:906:8452:b0:9b2:a7c9:fcfe with SMTP id e18-20020a170906845200b009b2a7c9fcfemr2088257ejy.36.1696434886918; Wed, 04 Oct 2023 08:54:46 -0700 (PDT) Received: from [192.168.188.57] (dynamic-077-000-040-057.77.0.pool.telefonica.de. [77.0.40.57]) by smtp.gmail.com with ESMTPSA id b17-20020a170906491100b009adc81bb544sm3016878ejq.106.2023.10.04.08.54.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Oct 2023 08:54:41 -0700 (PDT) Message-ID: <097e48f1-b915-4d6c-b68e-8ee282bc6de5@redhat.com> Date: Wed, 4 Oct 2023 17:54:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [committed] libstdc++: Define std::numeric_limits<_FloatNN> before C++23 To: Jonathan Wakely , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org References: <20230817203213.1131496-1-jwakely@redhat.com> Cc: Pranav Kant From: Stephan Bergmann In-Reply-To: <20230817203213.1131496-1-jwakely@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 8/17/23 22:32, Jonathan Wakely via Libstdc++ wrote: > Tested x86_64-linux. Pushed to trunk. > > -- >8 -- > > The extended floating-point types such as _Float32 are supported by GCC > prior to C++23, you just can't use the standard-conforming names from > to refer to them. This change defines the specializations of > std::numeric_limits for those types for older dialects, not only for > C++23. > > libstdc++-v3/ChangeLog: > > * include/bits/c++config (__gnu_cxx::__bfloat16_t): Define > whenever __BFLT16_DIG__ is defined, not only for C++23. > * include/std/limits (numeric_limits): Likewise. > (numeric_limits<_Float16>, numeric_limits<_Float32>) > (numeric_limits<_Float64>): Likewise for other extended > floating-point types. > --- > libstdc++-v3/include/bits/c++config | 4 +- > libstdc++-v3/include/std/limits | 194 +++++++++++++++------------- > 2 files changed, 103 insertions(+), 95 deletions(-) > [...] > diff --git a/libstdc++-v3/include/std/limits b/libstdc++-v3/include/std/limits > index 52b19ef8264..7a59e7520eb 100644 > --- a/libstdc++-v3/include/std/limits > +++ b/libstdc++-v3/include/std/limits > @@ -1890,189 +1890,197 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION [...] > __glibcxx_float_n(64) > #endif > -#ifdef __STDCPP_FLOAT128_T__ > +#ifdef __FLT128_DIG__ > __glibcxx_float_n(128) > #endif > #undef __glibcxx_float_n [...] The above change (from __STDCPP_FLOAT128_T__ to __FLT128_DIG__) now started to cause issues with Clang on Clang 18 trunk: * Clang does not support a _Float128 type. * Clang does not predefine __STDCPP_FLOAT128_T__. * But since "[clang] Predefined macros for float128 support (#67196)", Clang 18 trunk does predefine __FLT128_DIG__ now. Which causes > $ cat test.cc > #include > $ clang++ -fsyntax-only test.cc > In file included from test.cc:1: > /home/sbergman/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/14.0.0/../../../../include/c++/14.0.0/limits:1995:1: error: use of undeclared identifier '_Float128' > 1995 | __glibcxx_float_n(128) > | ^ > /home/sbergman/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/14.0.0/../../../../include/c++/14.0.0/limits:1903:27: note: expanded from macro '__glibcxx_float_n' > 1903 | struct numeric_limits<_Float##BITSIZE> \ > | ^ > :36:1: note: expanded from here > 36 | _Float128 > | ^ > 1 error generated. (I don't know whether or not it is useful for Clang to predefine __FLT128_DIG__ when not providing a _Float128 type. I assume "ISO/IEC TS 18661-3:2015", as referenced by the C++ standard, might be relevant here, but don't know that document. I added Pranav, the author of the relevant Clang commit, in cc here.)