public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Olivier Hainque <hainque@adacore.com>
To: Jonathan Wakely <jwakely.gcc@gmail.com>
Cc: Olivier Hainque <hainque@adacore.com>,
	Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
	libstdc++ <libstdc++@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Define _C99 in libstdc++ vxworks/os_defines.h
Date: Fri, 10 Dec 2021 17:15:51 +0100	[thread overview]
Message-ID: <0FE98CF1-19DE-41A5-9A6D-A54B25D6F29E@adacore.com> (raw)
In-Reply-To: <CAH6eHdRjX+KmMsLbr-M75hyvj2PCxJ2RQ9iPaBmL1WpG_seowg@mail.gmail.com>



> On 10 Dec 2021, at 16:42, Jonathan Wakely <jwakely.gcc@gmail.com> wrote:
> 
> 
> OK to commit then, thanks.
> 
> The comment is a bit misleading though:
> 
> +// libstdc++ relies on C99 features for virtually all versions of C++,
> +// up to at least C++98.
> +#undef _C99
> +#define _C99 1
> 
> The "up to" seems backwards, I'd expect it to say "down to" or "as far
> back as at least C++98".
> 
> But there's nothing older than C++98 anyway, so this just means "all
> versions", there's no "virtually" about it.
> 
> Please just say "libstdc++ relies on C99 features for all versions of C++".

Sure, thanks Jonathan. Yes, I agree the comment is confused.
I hesitated between a couple of perspectives and just mixed
things up.

Thanks for your prompt review!

Olivier

      reply	other threads:[~2021-12-10 16:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-10 15:06 Olivier Hainque
2021-12-10 15:15 ` Rasmus Villemoes
2021-12-10 15:42   ` Jonathan Wakely
2021-12-10 16:15     ` Olivier Hainque [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0FE98CF1-19DE-41A5-9A6D-A54B25D6F29E@adacore.com \
    --to=hainque@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely.gcc@gmail.com \
    --cc=libstdc++@gcc.gnu.org \
    --cc=rasmus.villemoes@prevas.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).