public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Michael Weghorn <m.weghorn@posteo.de>
To: Jonathan Wakely <jwakely@redhat.com>
Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [PING] [PATCH] libstdc++: Pretty printers for std::_Bit_reference, std::_Bit_iterator and std::_Bit_const_iterator
Date: Wed, 2 Dec 2020 08:01:58 +0100	[thread overview]
Message-ID: <0a52e4d3-fc82-bf92-598f-93132156869c@posteo.de> (raw)
In-Reply-To: <20201201213711.GM2309743@redhat.com>

On 01/12/2020 22.37, Jonathan Wakely wrote:
> On 27/11/20 16:33 +0000, Jonathan Wakely wrote:
>> On 25/11/20 15:05 +0100, Michael Weghorn via Libstdc++ wrote:
>>> I'd like to ping for this patch:
>>> https://gcc.gnu.org/pipermail/gcc-patches/2020-September/553870.html
>>
>> Thanks, I'll take another look next week.
> 
> I've applied the patch now, thanks.
> 
> I adjusted it slightly, to add a test for const_iterator to the C++98
> test, simple.cc, consistent with the C++11 one, simple11.cc

Thanks!

> 
> Tested powerpc64le-linux, committed to trunk.
> 
> Thanks again for the patch, and your patience.
> 
> 
>>> Michael
>>>
>>> On 11/10/2020 19.22, Michael Weghorn via Gcc-patches wrote:
>>>> On 22/09/2020 12.04, Jonathan Wakely wrote:
>>>>> On 14/09/20 16:49 +0200, Michael Weghorn via Libstdc++ wrote:
>>>>>> Hi,
>>>>>>
>>>>>> the attached patch implements pretty printers relevant for iteration
>>>>>> over std::vector<bool>, thus handling the TODO
>>>>>> added in commit 36d0dada6773d7fd7c5ace64c90e723930a3b81e
>>>>>> ("Have std::vector printer's iterator return bool for vector<bool>",
>>>>>> 2019-06-19):
>>>>>>
>>>>>>    TODO add printer for vector<bool>'s _Bit_iterator and
>>>>>> _Bit_const_iterator
>>>>>>
>>>>>> Tested on x86_64-pc-linux-gnu (Debian testing).
>>>>>>
>>>>>> I haven't filed any copyright assignment for GCC yet, but I'm 
>>>>>> happy to
>>>>>> do so when pointed to the right place.
>>>>>
>>>>> Thanks for the patch! I'll send you the form to start the copyuright
>>>>> assignment process.
>>>>>
>>>>>
>>>>
>>>> Thanks! The copyright assignment is done now. Is there anything else to
>>>> do from my side at the moment?
>>>>
>>>

      reply	other threads:[~2020-12-02  7:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-14 14:49 Michael Weghorn
2020-09-22 10:04 ` Jonathan Wakely
2020-10-11 17:22   ` Michael Weghorn
2020-11-25 14:05     ` [PING] " Michael Weghorn
2020-11-27 16:33       ` Jonathan Wakely
2020-12-01 21:37         ` Jonathan Wakely
2020-12-02  7:01           ` Michael Weghorn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0a52e4d3-fc82-bf92-598f-93132156869c@posteo.de \
    --to=m.weghorn@posteo.de \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jwakely@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).