From: "François Dumont" <frs.dumont@gmail.com>
To: Jonathan Wakely <jwakely@redhat.com>,
libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org
Subject: Re: [committed] libstdc++: Add noexcept to __replacement_assert [PR101429]
Date: Thu, 15 Jul 2021 19:20:25 +0200 [thread overview]
Message-ID: <0cfafdf4-e697-4234-e01d-df259abd10ac@gmail.com> (raw)
In-Reply-To: <YPBTiCH39BU0bs7A@redhat.com>
On 15/07/21 5:26 pm, Jonathan Wakely via Libstdc++ wrote:
> This results in slightly smaller code when assertions are enabled when
> either using Clang (because it adds code to call std::terminate when
> potentially-throwing functions are called in a noexcept function) or a
> freestanding or non-verbose build (because it doesn't use printf).
>
> Signed-off-by: Jonathan Wakely <jwakely@redhat.com>
>
> libstdc++-v3/ChangeLog:
>
> PR libstdc++/101429
> * include/bits/c++config (__replacement_assert): Add noexcept.
> [!_GLIBCXX_VERBOSE] (__glibcxx_assert_impl): Use __builtin_trap
> instead of __replacement_assert.
>
> Tested powerpc64le-linux. Committed to trunk.
>
ChangeLog is talking about __builtin_trap but there is none in the
attached patch.
next prev parent reply other threads:[~2021-07-15 17:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-15 15:26 Jonathan Wakely
2021-07-15 17:20 ` François Dumont [this message]
2021-07-15 18:46 ` Jonathan Wakely
2021-07-16 14:38 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cfafdf4-e697-4234-e01d-df259abd10ac@gmail.com \
--to=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).