From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) by sourceware.org (Postfix) with ESMTPS id E5D9E3858D33 for ; Thu, 26 May 2022 09:40:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E5D9E3858D33 Received: by mail-wr1-x42e.google.com with SMTP id p10so1410032wrg.12 for ; Thu, 26 May 2022 02:40:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=YJvi5A8C2CJr3O9Rvz5PAMyjH4sx8vI8asQWyg94csw=; b=ag0J6uvci2saUMeE3B2EiWMAI+1iA1HtY3YbleWKJMzIvSkLKMtIqgftNz2Slu++YR nK+EByPWOf6iGnRNzx7xkWb10BIGGiIlHupPtwyiTBYz/LWfo3D3D96thXPnP6l0TWfd JEijv9X5arrn/D2ypNU3E0hEFzWlAQlEdWKbowudraIR80yXs3ukWLvmj4UTbGMj7mhB N43pFfpH4Cs9PRJSCChxhlZ60A/6/agMCbdXqsmrYGHmUMhhTH26O+745PkA11b8naSs UWUPmKLR8XSZfjVGQ/T0rImOwrmsuJq/ojQKveiYgkePE47QGXjDTAZLppBAxDfDlkiP Ra5A== X-Gm-Message-State: AOAM532db9LPRmF6uju8dTQUwXgL6fIwl9J2cMVWWyN+Bzkv7N1AgksC +wKPAYSp1l9zxk+MRU5FDY4= X-Google-Smtp-Source: ABdhPJzuR5jDC3M+ikZzwmdz0lv/MFJg1LS6slnyL1eQFr4hI8lREDSyFsDlcBqldWhr+TuDZS0SiA== X-Received: by 2002:a5d:6809:0:b0:210:af0:64b0 with SMTP id w9-20020a5d6809000000b002100af064b0mr1875937wru.202.1653558022584; Thu, 26 May 2022 02:40:22 -0700 (PDT) Received: from ?IPV6:2a01:e0a:1dc:b1c0:d5a9:f150:c5f6:8701? ([2a01:e0a:1dc:b1c0:d5a9:f150:c5f6:8701]) by smtp.googlemail.com with ESMTPSA id d17-20020adffbd1000000b0020d09f0b766sm1252202wrs.71.2022.05.26.02.40.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 May 2022 02:40:22 -0700 (PDT) Message-ID: <0fb0ade2-7d75-08fa-d65f-7d71a591681b@gmail.com> Date: Thu, 26 May 2022 11:40:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH][_GLIBCXX_INLINE_VERSION] Fix std::span pretty printer Content-Language: fr To: Jonathan Wakely Cc: "libstdc++@gcc.gnu.org" References: From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libstdc++@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libstdc++ mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2022 09:40:25 -0000 On 26/05/22 11:21, Jonathan Wakely wrote: > On Thu, 26 May 2022 at 00:38, Jonathan Wakely wrote: >> On Thu, 26 May 2022 at 00:34, Jonathan Wakely wrote: >>> On Wed, 25 May 2022 at 21:29, François Dumont via Libstdc++ >>> wrote: >>>> Hi >>>> >>>> Here is a patch to fix std::span pretty printer in versioned >>>> namespace mode. >>>> >>>> Note that there is still a problem with std::atomic after this patch. >>>> >>>> got: $13 = std::atomic> (empty) = {get() = 0x0} >>>> FAIL: libstdc++-prettyprinters/cxx20.cc print spe >> Does this fix it? >> >> --- a/libstdc++-v3/python/libstdcxx/v6/printers.py >> +++ b/libstdc++-v3/python/libstdcxx/v6/printers.py >> @@ -1734,6 +1734,7 @@ class StdAtomicPrinter: >> impl = val['_M_impl'] >> self.shptr_printer = SharedPointerPrinter(typename, impl) >> self.children = self._shptr_children >> + self.typename = self.typename.replace(self.value_type.tag, typ) >> >> def _shptr_children(self): >> return SmartPtrIterator(self.shptr_printer.pointer) >> >> >> I'll test it with a versioned-namespace build tomorrow. > No, that didn't work, but the attached patch does. Pushed to trunk. Great, I just pushed mine too. Thanks