From: Matthias Kretz <m.kretz@gsi.de>
To: <gcc-patches@gcc.gnu.org>, <libstdc++@gcc.gnu.org>
Cc: Jonathan Wakely <jwakely@redhat.com>
Subject: Re: [PATCH 4/8] libstdc++: Add missing constexpr on simd shift implementation
Date: Thu, 23 Feb 2023 12:33:38 +0100 [thread overview]
Message-ID: <13641044.RDIVbhacDa@minbar> (raw)
In-Reply-To: <CACb0b4=OBTx80+5ohgDso_rZWiSwwQ2XBY6NeaqNJEqKOc-xrw@mail.gmail.com>
On Thursday, 23 February 2023 12:07:11 CET Jonathan Wakely wrote:
> On Thu, 23 Feb 2023 at 08:55, Matthias Kretz via Libstdc++
>
> <libstdc++@gcc.gnu.org> wrote:
> > Resolves -Wtautological-compare warnings about `if
> > (__builtin_is_constant_evaluated())` in the implementations of these
> > functions.
>
> The 'inline' is redundant now, because these are unconditionally
> constexpr which implies inline.
In the simd implementation I always have to make a conscious choice of
always_inline vs. inline. Having the inline keyword there helps documenting
that choice and helps revisiting all not-always_inline functions quickly.
--
──────────────────────────────────────────────────────────────────────────
Dr. Matthias Kretz https://mattkretz.github.io
GSI Helmholtz Centre for Heavy Ion Research https://gsi.de
stdₓ::simd
──────────────────────────────────────────────────────────────────────────
next prev parent reply other threads:[~2023-02-23 11:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 8:48 [PATCH 0/8] std::experimental::simd patchset Matthias Kretz
2023-02-23 8:49 ` [PATCH 1/8] libstdc++: Simplify three helper functions into one Matthias Kretz
2023-02-23 11:05 ` Jonathan Wakely
2023-02-23 8:49 ` [PATCH 2/8] libstdc++: Fix simd build failure on clang Matthias Kretz
2023-02-23 11:06 ` Jonathan Wakely
2023-02-23 8:49 ` [PATCH 3/8] libstdc++: More efficient masked inc-/decrement implementation Matthias Kretz
2023-02-24 17:12 ` Jonathan Wakely
2023-02-23 8:49 ` [PATCH 4/8] libstdc++: Add missing constexpr on simd shift implementation Matthias Kretz
2023-02-23 11:07 ` Jonathan Wakely
2023-02-23 11:33 ` Matthias Kretz [this message]
2023-02-23 8:49 ` [PATCH 5/8] libstdc++: Always-inline most of non-cmath fixed_size implementation Matthias Kretz
2023-02-24 17:10 ` Jonathan Wakely
2023-02-23 8:50 ` [PATCH 6/8] libstdc++: Fix formatting Matthias Kretz
2023-02-24 17:14 ` Jonathan Wakely
2023-02-24 18:44 ` Matthias Kretz
2023-02-23 8:50 ` [PATCH 7/8] libstdc++: Fix -Wsign-compare issue Matthias Kretz
2023-02-23 11:07 ` Jonathan Wakely
2023-02-23 8:50 ` [PATCH 8/8] libstdc++: Test that integral simd reductions are precise Matthias Kretz
2023-02-23 11:08 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13641044.RDIVbhacDa@minbar \
--to=m.kretz@gsi.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely@redhat.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).