From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1292F3858439 for ; Wed, 20 Dec 2023 15:56:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1292F3858439 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1292F3858439 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703087762; cv=none; b=FNy/txE9zU/abY4V8FWn4XRoPQwLXTxhhA9O1twsf2LVpVS2WpqDWQCbFzfCFwT3IkRzGAP8nbgS8F3bY4XVRHXitoz/ARgndxiYzLW4ud8eg0ueRuGbvpVb+h+iDN3N7gOWrpWwK9rVIPI43NKfrf+uVeskecGPt5Ye0rIYdac= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703087762; c=relaxed/simple; bh=1KAdO1kJWyoq0NRksKTLr5nsq86eQI/hIWW7xq8BTb4=; h=DKIM-Signature:From:Date:To:Subject:Message-ID:MIME-Version; b=WxU6LBOPPy5ymmpO8cQ36O/U4kTW+8K3rGJSRVx+GLpG+WRLWfSj8dWlXopE53tMq3RO9trufIJW983iF1vbFCitG9+Lrz+u/sEifnaRP80yygRgMjjeV07wRUFLAgdJzxp0xi9tKV4gBokWtbW5DQzaPepAy6fKwdBNNc2S2bA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1703087760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=65wP8V4dpvUY8OcZx7RjAU9eFPuiWwjPRSuvPYKuGsQ=; b=aSLrqItliLqf/jW4m+Z4MXbdVYBVgM0zyYNrvG/vmceINvt6TXRvsOMbIq9PxvCVkirGyk Dd0oJBEXFvYG2p2kMezCDY0ubR3k9F6+QC2qxU1EdXFzXIgipMJngUkMB4mbQtzLsebjMx M5EVz8WayFaCHubzmFzxRMt3f8trgz4= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-287-e89OJ5n0OHu05x8roC6BOQ-1; Wed, 20 Dec 2023 10:55:58 -0500 X-MC-Unique: e89OJ5n0OHu05x8roC6BOQ-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-78106027453so214622285a.0 for ; Wed, 20 Dec 2023 07:55:58 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703087757; x=1703692557; h=mime-version:references:message-id:in-reply-to:subject:cc:to:date :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=65wP8V4dpvUY8OcZx7RjAU9eFPuiWwjPRSuvPYKuGsQ=; b=xImaI85umTG6o4fv3jwlTnCTU87Wni0eAWsjmbk9JAKzVWj2PhYhGYh+jjOs36LwvY 70UKwBmifxurfAEIW5nMyGRTS3pHbQ5vQtSNCbG+yWLwKZf8l4t7ufsx4cO26i5G5CSK xX8zIiA0PaEKlwHgsvJQWSiZDCbdkCs7+IJqB+JWbfbcBQNgY3GGxEvSviJW8r0rTTsw A0g63uNfxpD8Tuo7Z1pdyITMGTsOSh/Wno8tl/lmN8y/28lg1oxDMBbHMuDtyqiL9r8i 9n7Jx1YbLsvPJlOIUV5/64qj0Sk4A3Ft591JrDUOAaOv/ahNKKeL3ZeP972zEDyDnACR DvFw== X-Gm-Message-State: AOJu0YwGsaKmyBmMbPk9j7T0dGcpg5yQr3fsJ7pKCQb1MN/Tf3jmQr6h MCISKtqsHqfAFn3+udhXDKg/QHEn+tMzWYbyCgtLLLXm87M3iamoqvm+FSYdOiSyGFdrpbt/k5E PaMOVyLsndGdPxLk= X-Received: by 2002:a05:620a:40c9:b0:77f:b8f9:d183 with SMTP id g9-20020a05620a40c900b0077fb8f9d183mr10833632qko.108.1703087757679; Wed, 20 Dec 2023 07:55:57 -0800 (PST) X-Google-Smtp-Source: AGHT+IHD2tniXHI3RQgcrK3rEA6RE4GhCy441Gn2BUT+NILv0eD5v8Ydgoj9vFSZqmIH0HPzMWw1TQ== X-Received: by 2002:a05:620a:40c9:b0:77f:b8f9:d183 with SMTP id g9-20020a05620a40c900b0077fb8f9d183mr10833624qko.108.1703087757414; Wed, 20 Dec 2023 07:55:57 -0800 (PST) Received: from [192.168.1.130] (ool-457670bb.dyn.optonline.net. [69.118.112.187]) by smtp.gmail.com with ESMTPSA id az9-20020a05620a170900b0077f7ca37e5dsm8212qkb.105.2023.12.20.07.55.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 07:55:56 -0800 (PST) From: Patrick Palka X-Google-Original-From: Patrick Palka Date: Wed, 20 Dec 2023 10:55:56 -0500 (EST) To: Sandra Loosemore cc: Ken Matsui , gcc-patches@gcc.gnu.org, libstdc++@gcc.gnu.org Subject: Re: [PATCH v26 00/23] Optimize type traits compilation performance In-Reply-To: Message-ID: <136f0838-9c65-c7e4-3d8d-acf49d08d887@idea> References: <20231024020424.699427-1-kmatsui@gcc.gnu.org> <20231207051513.969952-1-kmatsui@gcc.gnu.org> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,RCVD_IN_SORBS_WEB,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 19 Dec 2023, Sandra Loosemore wrote: > On 12/6/23 22:11, Ken Matsui wrote: > > This patch series optimizes type traits compilation performance by > > implementing built-in type traits and using them in libstdc++. > > I'm finding that all the new g++.dg/ext/is_*.C testcases added by this patch > series are failing due > to the "#include ". If that is supposed to refer to the file > of that name in the libstdc++ testcase, there's no gcc option being passed to > add that location to the include search path. That .h file includes other > header files from the libstdc++ testsuite so just copying it into the same > directory as the new g++ tests doesn't work. Can you fix this, somehow? Looks like the testcases only use the trivial definition of __gnu_test::ClassType from the header, so perhaps we can just define it locally and remove this header include (which IIUC is intended to be used for library tests run by the libstdc++ test harness, not front-end tests). Ken, do you want to submit a patch for that? (A full bootstrap + regtest wouldn't be necessary, it should suffice to re-run the changed tests via e.g. make check RUNTESTFLAGS="dg.exp=*ext*") > > Target is nios2-elf, if that matters. > > -Sandra > >