From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 34A29384B000 for ; Tue, 30 Apr 2024 21:00:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 34A29384B000 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 34A29384B000 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714510809; cv=none; b=h09WqOEtZ6UcexHjkyqPic+zcGoq7eE2EOef0LOuR2R6xzurycJjKAWzP+h3NmjnCISSG1keZ530emvn2SYmGxqjVOguzxaJugT41lqVwbywAUlyh/45AZsc8WWkLlxG8ixFnSB5E01T2qcJ+hpPy5TF1LvPvOqVXNCrgxJ8/vg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1714510809; c=relaxed/simple; bh=f+KWe5tnedWPcJFk2kUM15L+2RkUkV8xaJN+0eyae8Y=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=LHPNToD24gmUGOWbgE6sfM+BmWthCUsBhiKrkwOKFtjaY8/ZI/K9XvI9ZExjEzw71L+bEOCyA2aAKqqpOTytDzDUVBhPbR5+JY4ZYAKmvWPG61c9QLqCHv265syXukm4wR60RP9WGTNtFwc5GIaD3pyV2CljsTDu42ynDL7dK2o= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1714510806; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FZGSI9EPHrfsNvogm/C2VYuw/WaIWZRBVegjRHCj5og=; b=IjFUbdeczBvtY2aUWXN8YKZ3PDCJRPAyojRNhNzv40EBso2l1DQ95fqm1aUnwSvBlObVO7 2CF/+HSUlhaMWUWdlh5D1e/JwQ+DYcEVfBV5pVZgS2tvrNL6kdQtktQCoXxvMEK0JXHGwu F7gFVshv4avHIgiA4C1tFM9NGKdR/Sg= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-201-4kolC8wdO56aw3zP8Julcg-1; Tue, 30 Apr 2024 17:00:05 -0400 X-MC-Unique: 4kolC8wdO56aw3zP8Julcg-1 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-1ec5dc29f95so9002935ad.3 for ; Tue, 30 Apr 2024 14:00:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714510804; x=1715115604; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FZGSI9EPHrfsNvogm/C2VYuw/WaIWZRBVegjRHCj5og=; b=Gskk6KQR6epvVmG1CfYVyEurK240saTT30bvBZtvdnnyfvY3iR0CKOIJrBrWYCNzh3 xvT8TQ7LK6apLlm5KMQsOZPPZR5WN/gpGOitNx/R830sL8sZDObNd8zUpUCnJvJEn0YQ gvlZFkWKDlGGdkqO1m1Y6mGccWdiycrkBN6C28jE6D4Amk/6auFNAcese1TD8H1+opCV 4lNXIOzWT8fXZGjsxPm4lUhjyHGoW4SYmH3S5TvXx04L536jOWsWKooKVbJVeZvjvx7a KiZ/U+sh9ArdH7acVRqCrPADNdTlDhMoARz2cAbJuodpw0wiQutWytoljr17suxJqDom cxRw== X-Gm-Message-State: AOJu0YwpxtOcb+fz1D1pXqv2bnNT4F+12mzHb0mHdNUnZQBmXkr1of8b UyrLzodWywdRBYwj5FeUewSZD1aHRXTkQqZgEbFY0+t8W5aR7BivbYRQ+YtowO77nK5aWDvTvCT QqTm/COaxhgd26PmWg/HaJDS72NSEHoEEf2/+HAc0mX4OMA4UysaD5cV2M4AD X-Received: by 2002:a17:903:32d2:b0:1e0:bae4:48f9 with SMTP id i18-20020a17090332d200b001e0bae448f9mr684432plr.32.1714510804142; Tue, 30 Apr 2024 14:00:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGbFcjP2Wtg2m3ELjZ6DDis//qhMtxf2712cEY3jZtx/DhcmogrGGmU4IKjoWuKNxs0QRN6JA== X-Received: by 2002:a17:903:32d2:b0:1e0:bae4:48f9 with SMTP id i18-20020a17090332d200b001e0bae448f9mr684410plr.32.1714510803775; Tue, 30 Apr 2024 14:00:03 -0700 (PDT) Received: from [192.168.1.130] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id b8-20020a170903228800b001e3e409722csm2311515plh.5.2024.04.30.14.00.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Apr 2024 14:00:03 -0700 (PDT) Message-ID: <1bec0f18-6c44-46e3-87d4-f6bb81d3a4e4@redhat.com> Date: Tue, 30 Apr 2024 17:00:01 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v14 13/26] c++: Implement __remove_all_extents built-in trait To: Ken Matsui , gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org References: <20240221093616.4001742-1-kmatsui@gcc.gnu.org> <20240228192843.188979-1-kmatsui@gcc.gnu.org> <20240228192843.188979-14-kmatsui@gcc.gnu.org> From: Jason Merrill In-Reply-To: <20240228192843.188979-14-kmatsui@gcc.gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/28/24 11:26, Ken Matsui wrote: > This patch implements built-in trait for std::remove_all_extents. OK. > gcc/cp/ChangeLog: > > * cp-trait.def: Define __remove_all_extents. > * semantics.cc (finish_trait_type): Handle > CPTK_REMOVE_ALL_EXTENTS. > > gcc/testsuite/ChangeLog: > > * g++.dg/ext/has-builtin-1.C: Test existence of > __remove_all_extents. > * g++.dg/ext/remove_all_extents.C: New test. > > Signed-off-by: Ken Matsui > --- > gcc/cp/cp-trait.def | 1 + > gcc/cp/semantics.cc | 3 +++ > gcc/testsuite/g++.dg/ext/has-builtin-1.C | 3 +++ > gcc/testsuite/g++.dg/ext/remove_all_extents.C | 16 ++++++++++++++++ > 4 files changed, 23 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/ext/remove_all_extents.C > > diff --git a/gcc/cp/cp-trait.def b/gcc/cp/cp-trait.def > index 577c96d579b..933c8bcbe68 100644 > --- a/gcc/cp/cp-trait.def > +++ b/gcc/cp/cp-trait.def > @@ -98,6 +98,7 @@ DEFTRAIT_EXPR (IS_UNION, "__is_union", 1) > DEFTRAIT_EXPR (IS_VOLATILE, "__is_volatile", 1) > DEFTRAIT_EXPR (REF_CONSTRUCTS_FROM_TEMPORARY, "__reference_constructs_from_temporary", 2) > DEFTRAIT_EXPR (REF_CONVERTS_FROM_TEMPORARY, "__reference_converts_from_temporary", 2) > +DEFTRAIT_TYPE (REMOVE_ALL_EXTENTS, "__remove_all_extents", 1) > DEFTRAIT_TYPE (REMOVE_CV, "__remove_cv", 1) > DEFTRAIT_TYPE (REMOVE_CVREF, "__remove_cvref", 1) > DEFTRAIT_TYPE (REMOVE_EXTENT, "__remove_extent", 1) > diff --git a/gcc/cp/semantics.cc b/gcc/cp/semantics.cc > index 58696225fc4..078424dac23 100644 > --- a/gcc/cp/semantics.cc > +++ b/gcc/cp/semantics.cc > @@ -12785,6 +12785,9 @@ finish_trait_type (cp_trait_kind kind, tree type1, tree type2, > type1 = TREE_TYPE (type1); > return build_pointer_type (type1); > > + case CPTK_REMOVE_ALL_EXTENTS: > + return strip_array_types (type1); > + > case CPTK_REMOVE_CV: > return cv_unqualified (type1); > > diff --git a/gcc/testsuite/g++.dg/ext/has-builtin-1.C b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > index 5d5cbe3b019..85b74bd676b 100644 > --- a/gcc/testsuite/g++.dg/ext/has-builtin-1.C > +++ b/gcc/testsuite/g++.dg/ext/has-builtin-1.C > @@ -176,6 +176,9 @@ > #if !__has_builtin (__reference_converts_from_temporary) > # error "__has_builtin (__reference_converts_from_temporary) failed" > #endif > +#if !__has_builtin (__remove_all_extents) > +# error "__has_builtin (__remove_all_extents) failed" > +#endif > #if !__has_builtin (__remove_cv) > # error "__has_builtin (__remove_cv) failed" > #endif > diff --git a/gcc/testsuite/g++.dg/ext/remove_all_extents.C b/gcc/testsuite/g++.dg/ext/remove_all_extents.C > new file mode 100644 > index 00000000000..60ade2ade7f > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ext/remove_all_extents.C > @@ -0,0 +1,16 @@ > +// { dg-do compile { target c++11 } } > + > +#define SA(X) static_assert((X),#X) > + > +class ClassType { }; > + > +SA(__is_same(__remove_all_extents(int), int)); > +SA(__is_same(__remove_all_extents(int[2]), int)); > +SA(__is_same(__remove_all_extents(int[2][3]), int)); > +SA(__is_same(__remove_all_extents(int[][3]), int)); > +SA(__is_same(__remove_all_extents(const int[2][3]), const int)); > +SA(__is_same(__remove_all_extents(ClassType), ClassType)); > +SA(__is_same(__remove_all_extents(ClassType[2]), ClassType)); > +SA(__is_same(__remove_all_extents(ClassType[2][3]), ClassType)); > +SA(__is_same(__remove_all_extents(ClassType[][3]), ClassType)); > +SA(__is_same(__remove_all_extents(const ClassType[2][3]), const ClassType));