From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10700 invoked by alias); 28 Sep 2017 10:58:08 -0000 Mailing-List: contact libstdc++-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libstdc++-owner@gcc.gnu.org Received: (qmail 10682 invoked by uid 89); 28 Sep 2017 10:58:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:904, HContent-Transfer-Encoding:8bit X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 28 Sep 2017 10:58:07 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 92422CF821; Thu, 28 Sep 2017 10:58:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 92422CF821 Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jwakely@redhat.com Received: from localhost (unknown [10.33.36.48]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE7707F49E; Thu, 28 Sep 2017 10:58:04 +0000 (UTC) Date: Thu, 28 Sep 2017 10:58:00 -0000 From: Jonathan Wakely To: =?iso-8859-1?Q?Fran=E7ois?= Dumont Cc: libstdc++@gcc.gnu.org, gcc-patches , Petr Ovtchenkov Subject: Re: [PATCH] streambuf_iterator: avoid debug-dependent behaviour Message-ID: <20170928105804.GI4582@redhat.com> References: <20170901091037.GW4582@redhat.com> <86fe822c-96c0-1167-68d9-d79729f3dec5@gmail.com> <20170908084740.5afaeae3@void-ptr.info> <5bef157d-1ae5-3e06-99eb-8f93ff18179b@gmail.com> <20170928105007.GH4582@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170928105007.GH4582@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.8.3 (2017-05-23) X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00097.txt.bz2 On 28/09/17 11:50 +0100, Jonathan Wakely wrote: >On 21/09/17 07:46 +0200, François Dumont wrote: >>Gentle reminder, ok to commit ? > >No. Could you and Petr please come to an agreement about what is >actually wrong with the current implementation, and agree on a >solution? > >Currently you're both just proposing patches that do different things, >without indicating why one patch is better than the other. > >I understand that we want to remove the debugmode-dependent behaviour, >but I'd like to see any other changes justified by references to the >standard. Here's a test we currently fail, but it looks like we should pass it: http://llvm.org/svn/llvm-project/libcxx/trunk/test/std/iterators/stream.iterators/istreambuf.iterator/istreambuf.iterator.cons/proxy.pass.cpp Do the changes either of you is proposing change this result?