From: Jonathan Wakely <jwakely@redhat.com>
To: Christophe Lyon <christophe.lyon@linaro.org>
Cc: David Edelsohn <dje.gcc@gmail.com>,
Ed Smith-Rowland <3dw4rd@verizon.net>,
"libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>,
Jonathan Wakely <jwakely.gcc@gmail.com>,
redi@gcc.gnu.org
Subject: Re: [PATCH libstdc++/66689] comp_ellint_3 and ellint_3 return garbage values
Date: Mon, 20 Nov 2017 21:07:00 -0000 [thread overview]
Message-ID: <20171120210747.GI31922@redhat.com> (raw)
In-Reply-To: <20171120210154.GH31922@redhat.com>
On 20/11/17 21:01 +0000, Jonathan Wakely wrote:
>On 20/11/17 21:43 +0100, Christophe Lyon wrote:
>>On 20 November 2017 at 17:02, David Edelsohn <dje.gcc@gmail.com> wrote:
>>>This patch has introduced new regressions on at least PowerPC and AArch64.
>>>
>>>FAIL: ext/special_functions/hyperg/check_value.cc execution test
>>>FAIL: tr1/5_numerical_facilities/special_functions/17_hyperg/check_value.cc
>>>execution test
>>>
>>>Thanks, David
>>
>>On AArch64 and ARM, I have also noticed
>>FAIL: special_functions/18_riemann_zeta/check_value.cc (test for excess errors)
>>UNRESOLVED: special_functions/18_riemann_zeta/check_value.cc
>>compilation failed to produce executable
>>because:
>>/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc:
>>In function 'void test(const testcase_riemann_zeta<Ret> (&)[Num],
>>Ret)':
>>/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc:292:
>>error: 'riemann_zeta' is not a member of 'std'
>>/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc:292:
>>note: suggested alternative: 'remainder'
>>compiler exited with status 1
>
>The problem is that { dg-addition-options } was changed to dg-options,
>and so the first dg-options that enables the special functions is not
>used:
>
>--- a/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc
>+++ b/libstdc++-v3/testsuite/special_functions/18_riemann_zeta/check_value.cc
>@@ -21,7 +21,7 @@
>// riemann_zeta
>
>// This can take long on simulators, timing out the test.
>-// { dg-additional-options "-DMAX_ITERATIONS=5" { target simulator } }
>+// { dg-options "-DMAX_ITERATIONS=5" { target simulator } }
>
I have a script to check dejagnu directives, and it says:
testsuite/tr1/5_numerical_facilities/special_functions/20_riemann_zeta/check_value_neg.cc has multiple dg-options directives
testsuite/ext/special_functions/airy_ai/check_nan.cc has dg-options after dg-add-options
testsuite/ext/special_functions/hyperg/check_nan.cc has dg-options after dg-add-options
testsuite/ext/special_functions/conf_hyperg/check_nan.cc has dg-options after dg-add-options
testsuite/ext/special_functions/airy_bi/check_nan.cc has dg-options after dg-add-options
testsuite/special_functions/02_assoc_legendre/check_nan.cc has dg-options after dg-add-options
testsuite/special_functions/14_expint/check_nan.cc has dg-options after dg-add-options
testsuite/special_functions/12_ellint_2/check_nan.cc has dg-options after dg-add-options
testsuite/special_functions/09_cyl_bessel_k/check_nan.cc has dg-options after dg-add-options
testsuite/special_functions/21_sph_neumann/check_nan.cc has dg-options after dg-add-options
testsuite/special_functions/15_hermite/check_nan.cc has dg-options after dg-add-options
testsuite/special_functions/19_sph_bessel/check_nan.cc has dg-options after dg-add-options
testsuite/special_functions/05_comp_ellint_2/check_nan.cc has dg-options after dg-add-options
testsuite/special_functions/11_ellint_1/check_nan.cc has dg-options after dg-add-options
testsuite/special_functions/17_legendre/check_nan.cc has dg-options after dg-add-options
testsuite/special_functions/10_cyl_neumann/check_nan.cc has dg-options after dg-add-options
testsuite/special_functions/06_comp_ellint_3/check_nan.cc has dg-options after dg-add-options
testsuite/special_functions/06_comp_ellint_3/pr66689.cc has dg-options after dg-add-options
testsuite/special_functions/01_assoc_laguerre/check_nan.cc has dg-options after dg-add-options
testsuite/special_functions/16_laguerre/check_nan.cc has dg-options after dg-add-options
testsuite/special_functions/13_ellint_3/check_nan.cc has dg-options after dg-add-options
testsuite/special_functions/13_ellint_3/pr66689.cc has dg-options after dg-add-options
testsuite/special_functions/07_cyl_bessel_i/check_nan.cc has dg-options after dg-add-options
testsuite/special_functions/18_riemann_zeta/check_nan.cc has dg-options after dg-add-options
testsuite/special_functions/18_riemann_zeta/check_value.cc has multiple dg-options directives
testsuite/special_functions/08_cyl_bessel_j/check_nan.cc has dg-options after dg-add-options
testsuite/special_functions/04_comp_ellint_1/check_nan.cc has dg-options after dg-add-options
testsuite/special_functions/03_beta/check_nan.cc has dg-options after dg-add-options
testsuite/special_functions/20_sph_legendre/check_nan.cc has dg-options after dg-add-options
For now I'll just fix the multiple dg-options one causing the FAILs.
next prev parent reply other threads:[~2017-11-20 21:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 16:02 David Edelsohn
2017-11-20 20:44 ` Christophe Lyon
2017-11-20 21:01 ` Jonathan Wakely
2017-11-20 21:07 ` Jonathan Wakely [this message]
2017-11-20 21:51 ` Jonathan Wakely
2017-12-05 18:36 ` David Edelsohn
-- strict thread matches above, loose matches on Subject: below --
2017-11-17 20:06 Ed Smith-Rowland
2017-11-17 20:54 ` Jonathan Wakely
2017-11-18 16:49 ` Ed Smith-Rowland
2017-11-20 16:39 ` Jonathan Wakely
2017-11-21 11:33 ` Florian Weimer
2017-11-21 13:35 ` Jonathan Wakely
2017-11-22 0:19 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171120210747.GI31922@redhat.com \
--to=jwakely@redhat.com \
--cc=3dw4rd@verizon.net \
--cc=christophe.lyon@linaro.org \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely.gcc@gmail.com \
--cc=libstdc++@gcc.gnu.org \
--cc=redi@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).