public inbox for libstdc++@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jonathan Wakely <jwakely@redhat.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
	gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: Rb_tree constructor optimization
Date: Sat, 19 May 2018 01:45:00 -0000	[thread overview]
Message-ID: <20180519014523.GU7974@redhat.com> (raw)
In-Reply-To: <20180517151032.GO7974@redhat.com>

On 17/05/18 16:10 +0100, Jonathan Wakely wrote:
>On 15/05/18 07:30 +0200, François Dumont wrote:
>>Here it is again even more simplified. Should I backport the Debug 
>>mode fix to 8 branch ?
>
>Yes, please do backport the include/debug/* changes.
>
>
>>    * include/bits/stl_tree.h
>>    (_Rb_tree_impl(_Rb_tree_impl&&, _Node_allocator&&)): New.
>>    (_Rb_tree(_Rb_tree&&, _Node_allocator&&, true_type)): New, use latter.
>>    (_Rb_tree(_Rb_tree&&, _Node_allocator&&, false_type)): New.
>>    (_Rb_tree(_Rb_tree&&, _Node_allocator&&)): Adapt, use latters.
>>    * include/debug/map.h
>>    (map(map&&, const_allocator_type&)): Add noexcept qualitication.
>>    * include/debug/multimap.h
>>    (multimap(multimap&&, const_allocator_type&)): Add noexcept 
>>qualification.
>>    * include/debug/set.h
>>    (set(set&&, const_allocator_type&)): Add noexcept qualitication.
>>    * include/debug/multiset.h
>>    (multiset(multiset&&, const_allocator_type&)): Add noexcept 
>>qualification.
>>    * testsuite/23_containers/map/cons/noexcept_default_construct.cc:
>>    Add checks.
>>    * testsuite/23_containers/map/cons/noexcept_move_construct.cc:
>>    Add checks.
>>    * testsuite/23_containers/multimap/cons/noexcept_default_construct.cc:
>>    Add checks.
>>    * testsuite/23_containers/multimap/cons/noexcept_move_construct.cc:
>>    Add checks.
>>    * testsuite/23_containers/multiset/cons/noexcept_default_construct.cc:
>>    Add checks.
>>    * testsuite/23_containers/multiset/cons/noexcept_move_construct.cc:
>>    Add checks.
>>    * testsuite/23_containers/set/cons/noexcept_default_construct.cc:
>>    Add checks.
>>    * testsuite/23_containers/set/cons/noexcept_move_construct.cc:
>>    Add checks.
>>
>>Ok to commit ?
>
>Yes, OK for trunk - thanks.
>
>

I'm seeing lots of new testsuite failures after this commit, see
https://gcc.gnu.org/ml/gcc-testresults/2018-05/msg02025.html


  reply	other threads:[~2018-05-19  1:45 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-01 19:56 François Dumont
2018-05-01 21:23 ` Ville Voutilainen
2018-05-01 21:28   ` Jakub Jelinek
2018-05-01 21:47     ` Ville Voutilainen
2018-05-01 22:42       ` Jonathan Wakely
2018-05-02 11:49 ` Jonathan Wakely
2018-05-03 20:11   ` François Dumont
2018-05-06 14:06   ` François Dumont
2018-05-11 12:16     ` Jonathan Wakely
2018-05-15  5:31       ` François Dumont
2018-05-17 15:10         ` Jonathan Wakely
2018-05-19  1:45           ` Jonathan Wakely [this message]
2018-05-19 23:16             ` H.J. Lu
2018-05-21 19:59               ` François Dumont
  -- strict thread matches above, loose matches on Subject: below --
2017-08-28 19:13 François Dumont
2017-09-08 15:50 ` Jonathan Wakely
2017-09-13 19:57   ` François Dumont
2017-09-14 20:04     ` François Dumont
2017-10-19  5:39       ` François Dumont

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180519014523.GU7974@redhat.com \
    --to=jwakely@redhat.com \
    --cc=frs.dumont@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=libstdc++@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).